Skip to content

Cortex-M: add a contiguous-layout pad operator - #22028

Draft
rascani wants to merge 3 commits into
gh/rascani/11/headfrom
gh/rascani/20/head
Draft

Cortex-M: add a contiguous-layout pad operator#22028
rascani wants to merge 3 commits into
gh/rascani/11/headfrom
gh/rascani/20/head

Conversation

@rascani

@rascani rascani commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Add cortex_m::pad_contiguous beside the existing pad. The two differ only in
whether the kernel has to work out the layout for itself: the existing operator
infers it, while this one requires the dim order to say the tensor is contiguous
and then indexes the padding by logical axis.

Not named after an axis order, because padding does not interpret axes the way
convolution and pooling do -- it pads whatever it is told to. What distinguishes
this entry point is that it never guesses. It accepts ranks one to four for the
same reason, so it can replace the inferring operator outright once serialized
programs no longer need that one, rather than sitting beside it forever.

Leave the existing operator alone. Its layout predicate is tolerant on purpose:
the tolerance short-circuits before the dim order is consulted, which is what
keeps it agreeing with the AOT pass for shapes whose serialized dim order cannot
name the channel axis. Two regression cases cover that, since every pre-existing
channels-last pad test used more than one channel and so missed it.

Local Corstone-300 run of the full Cortex-M suite and lintrunner.

Authored with Codex.

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22028

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 10 Unrelated Failures, 1 Unclassified Failure

As of commit ea98643 with merge base 8b93850 (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

  • trunk / test-coreml-delegate / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 128

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 21, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

[ghstack-poisoned]
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant