Cortex-M: keep NHWC channel broadcasts quantized - #21968
Draft
rascani wants to merge 8 commits into
Draft
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21968
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 6 Unrelated FailuresAs of commit c76dcc1 with merge base 8b93850 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 20, 2026
rascani
added a commit
that referenced
this pull request
Aug 20, 2026
Keep channel-broadcast add and multiply in int8 when supported explicit-layout anchors are reachable on both sides, including through activation patterns fused before layout formation. Derive the anchor set from the explicit operator map, lower accepted broadcasts to fixed quantized_add_nhwc and quantized_mul_nhwc schemas, and terminate only the affected region edge at backend barriers. Validate that every annotated unequal-shape operation became a logical-NHWC channel broadcast before runtime lowering. 16 host tests, 116 combined Buck tests, ten Cortex-M55 FVP cases, Cortex-M33 add and multiply execution, planned-memory parity for the branched broadcast case, and lintrunner. Authored with Codex. ghstack-source-id: 8837467 ghstack-comment-id: 5351512448 Pull-Request: #21968
rascani
added a commit
that referenced
this pull request
Aug 20, 2026
Keep channel-broadcast add and multiply in int8 when supported explicit-layout anchors are reachable on both sides, including through activation patterns fused before layout formation. Derive the anchor set from the explicit operator map, lower accepted broadcasts to fixed quantized_add_nhwc and quantized_mul_nhwc schemas, and terminate only the affected region edge at backend barriers. Validate that every annotated unequal-shape operation became a logical-NHWC channel broadcast before runtime lowering. 16 host tests, 116 combined Buck tests, ten Cortex-M55 FVP cases, Cortex-M33 add and multiply execution, planned-memory parity for the branched broadcast case, and lintrunner. Authored with Codex. ghstack-source-id: a55287a ghstack-comment-id: 5351512448 Pull-Request: #21968
rascani
added a commit
that referenced
this pull request
Aug 21, 2026
Keep channel-broadcast add and multiply in int8 when supported explicit-layout anchors are reachable on both sides, including through activation patterns fused before layout formation. Derive the anchor set from the explicit operator map and terminate only the affected region edge at backend barriers. Validate that every annotated unequal-shape operation became a channel broadcast the kernels can serve as a flat repeat before runtime lowering. Without this an SE-shaped block leaves its multiply as an unquantized aten operator and splits the layout region, doubling the boundary transposes. Local Corstone-300 run of the full Cortex-M suite and lintrunner. Authored with Codex. ghstack-source-id: c632891 ghstack-comment-id: 5351512448 Pull-Request: #21968
rascani
added a commit
that referenced
this pull request
Aug 21, 2026
Keep channel-broadcast add and multiply in int8 when supported explicit-layout anchors are reachable on both sides, including through activation patterns fused before layout formation. Derive the anchor set from the explicit operator map and terminate only the affected region edge at backend barriers. Validate that every annotated unequal-shape operation became a channel broadcast the kernels can serve as a flat repeat before runtime lowering. Without this an SE-shaped block leaves its multiply as an unquantized aten operator and splits the layout region, doubling the boundary transposes. Local Corstone-300 run of the full Cortex-M suite and lintrunner. Authored with Codex. ghstack-source-id: c632891 ghstack-comment-id: 5351512448 Pull-Request: #21968
rascani
added a commit
that referenced
this pull request
Aug 21, 2026
Keep channel-broadcast add and multiply in int8 when supported explicit-layout anchors are reachable on both sides, including through activation patterns fused before layout formation. Derive the anchor set from the explicit operator map and terminate only the affected region edge at backend barriers. Validate that every annotated unequal-shape operation became a channel broadcast the kernels can serve as a flat repeat before runtime lowering. Without this an SE-shaped block leaves its multiply as an unquantized aten operator and splits the layout region, doubling the boundary transposes. Local Corstone-300 run of the full Cortex-M suite and lintrunner. Authored with Codex. ghstack-source-id: 8a1d7ef ghstack-comment-id: 5351512448 Pull-Request: #21968
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep channel-broadcast add and multiply in int8 when supported explicit-layout
anchors are reachable on both sides, including through activation patterns fused
before layout formation.
Derive the anchor set from the explicit operator map and terminate only the
affected region edge at backend barriers. Validate that every annotated
unequal-shape operation became a channel broadcast the kernels can serve as a
flat repeat before runtime lowering.
Without this an SE-shaped block leaves its multiply as an unquantized aten
operator and splits the layout region, doubling the boundary transposes.
Local Corstone-300 run of the full Cortex-M suite and lintrunner.
Authored with Codex.