This one needs to go first: Repair keyext.api.client test compilation - #7
Merged
Conversation
unp1
force-pushed
the
fix/client-test-compilation
branch
from
June 22, 2026 17:04
7fd45f1 to
b1f529e
Compare
This was referenced Jun 22, 2026
unp1
changed the title
The test pre-loaded a response before the request was registered, so the reader could deliver it before callSync registered its waiting future; the handler then NPE'd and callSync blocked forever (no timeout). It is an artificial scenario and is covered deterministically by the client-stability PR's callSync test.
unp1
force-pushed
the
fix/client-test-compilation
branch
from
June 22, 2026 18:49
ff41056 to
61e6d2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order for the PRs
#7 first (you already retitled it) → main green.
Then the four base-#7 PRs (#8, #9, #10, #11) auto-retarget to main.
#6 (correctness) and #5 (Python correctness) → rebase on main.
#12 is stacked on #6, so it retargets to main after #6 lands.
./gradlew test(the CodeQualityunit-testsjob) fails onmainbecause thekeyext.api.clienttest sources do not compile — introduced byfbca050. This blocks CI on every PR that builds the whole project (e.g. #5).RPCLayerTestimportededu.kit.iti.formal.keyextclientjava.rpc.JsonRPC, a package that does not exist (the class isorg.key_project.key.api.client.JsonRPC).StartercalledBaseRemote.meta_version(), which does not exist; it is also a manual integration demo needing a built server jar, so it is now@Disabled.useJUnitPlatform()but had no JUnit dependency.This repairs all three so the module compiles and its tests run (
:keyext.api.client:testgreen). No production code is touched.PR has been created with AI tooling