Cache service-loader lookups for macros and script commands - #13
Merged
Conversation
wadoon
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance (
keyext.api): avoid repeatedServiceLoaderclasspath scans.getAvailableMacros/getAvailableScriptCommandsscanned the classpath (ClassLoaderUtil.loadServices) on every request.macro()scanned again on every call just to find one macro by name.Macros and script commands don't change at runtime, so they're now discovered once at construction: cached lists for the two
getAvailable*methods, and aname -> macromap for O(1) lookup inmacro().Dropped from the original review: #16 (
treeChildren"O(n) DFS"). On inspectionProof.findAnyis itself an O(n) BFS, so the suggested consolidation is no faster, and a custom serial→node index isn't worth the invalidation complexity. No change made there.Tests:
KeyApiServiceCacheTest(macros/commands non-empty and stable; unknown macro name rejected). The caching is structural, so these are no-regression guards rather than fail-on-old-code tests.Stacked on #7; retarget to
mainonce it merges. Touches only methods none of the other open PRs touch, so no conflicts.PR has been created with AI tooling