Run KeY operations on a dedicated executor instead of the common pool - #14
Merged
Merged
Conversation
unp1
force-pushed
the
fix/server-executor
branch
from
June 23, 2026 05:55
2f73806 to
f89129f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New-A (deferred until the stability/perf PRs landed): keep blocking KeY operations off the shared
ForkJoinPool.commonPool().auto/macro/script(andopenContract/save) block their worker thread for the whole proof run, and everything ran on the common pool — so a few concurrent long proofs could starve unrelated common-pool work across the JVM. This adds a dedicated daemonExecutorServiceand routes allsupplyAsyncoperations through it (async(...)helper); it's shut down onexit().computeAsync-based loading (loadKey/load/loadExample) is left on the common pool for now — a possible follow-up; the long-running proof operations are the main starvation risk and are now off it.Test:
KeyApiExecutorTestconfirms executor-dispatched operations still complete.Base note: this targets
fix/client-test-compilationbecause that branch (notmain) currently holds the merged stability/perf stack (#9/#10/#11/#13) — see my message about consolidating that branch intomain.PR has been created with AI tooling