Fix RPCLayer handler thread shutdown and unknown-id NPE - #8
Merged
Conversation
This was referenced Jun 22, 2026
unp1
force-pushed
the
fix/java-client-stability
branch
2 times, most recently
from
June 22, 2026 18:45
85d9874 to
a7136f9
Compare
The test pre-loaded a response before the request was registered, so the reader could deliver it before callSync registered its waiting future; the handler then NPE'd and callSync blocked forever (no timeout). It is an artificial scenario and is covered deterministically by the client-stability PR's callSync test.
unp1
force-pushed
the
fix/client-test-compilation
branch
from
June 22, 2026 18:49
ff41056 to
61e6d2f
Compare
unp1
force-pushed
the
fix/java-client-stability
branch
from
June 22, 2026 19:01
a7136f9 to
fc026c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two stability fixes in the hand-rolled Java client transport (
keyext.api.client):RPCLayer.dispose()only interrupted the reader thread, leaving the message-handler thread polling forever. It now interrupts both.Tests:
RPCLayerTestgainshandlerSurvivesUnknownResponseIdanddisposeStopsHandlerThread(both fail on the old code, pass with the fix).Stacked on #7 (the test-compilation fix) so CI is green; retarget to
mainonce #7 merges.PR has been created with AI tooling