Fix temp-file leak in loadKey and clear all per-proof caches on dispose - #10
Merged
Merged
Conversation
This was referenced Jun 22, 2026
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server resource cleanup (
keyext.api):loadKeywrote ajson-rpc-*.keyfile into the system temp dir on every call (loadKey/loadTerm/loadProblem) and never deleted it. The file is now removed in afinallyonce loading is done.ProofContainer.dispose()only clearedmapNode(which is never even populated). It now clears all per-proof caches incl. the printed-sequent cachemapGoalText. Note: the container is normally dropped frommapProofand GC'd on dispose, so this is eager/defensive release rather than a hard leak.Test:
LoadKeyTempFileTestassertsloadTermleaves no temp file behind (fails on the old code).Stacked on #7; retarget to
mainonce it merges. TouchesKeyApiImpl/KeyIdentificationsin different methods than #6, so they merge cleanly.PR has been created with AI tooling