Skip to content

OSPRH-32280: Add branch protection for shiftstack/shiftstack-qa#81948

Closed
imatza-rh wants to merge 1 commit into
openshift:mainfrom
imatza-rh:shiftstack-qa-branch-protection
Closed

OSPRH-32280: Add branch protection for shiftstack/shiftstack-qa#81948
imatza-rh wants to merge 1 commit into
openshift:mainfrom
imatza-rh:shiftstack-qa-branch-protection

Conversation

@imatza-rh

@imatza-rh imatza-rh commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Configure Prow branchprotector to protect the main branch of shiftstack/shiftstack-qa:

  • protect: true — prevents direct pushes to main
  • ansible-lint as required status check — CI must pass before merge

Pattern: Follows backube/pvc-transfer _prowconfig.yaml — same setup (external org, no ci-operator jobs, branch protection via branchprotector).

Context: Part of Prow onboarding for shiftstack-qa. Prow plugin + Tide config already merged (#81862). This adds the branch protection layer.

Jira: OSPRH-32280

Summary by CodeRabbit

  • Adds Prow branch protection for shiftstack/shiftstack-qa’s main branch.
  • Prevents direct pushes and requires the ansible-lint status check before merging.

Configure Prow branchprotector to protect the main branch with
ansible-lint as a required status check. This prevents direct
pushes and requires CI to pass before merge.

Pattern follows backube/pvc-transfer _prowconfig.yaml.
@openshift-ci-robot

openshift-ci-robot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@imatza-rh: This pull request references OSPRH-32280 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Configure Prow branchprotector to protect the main branch of shiftstack/shiftstack-qa:

  • protect: true — prevents direct pushes to main
  • ansible-lint as required status check — CI must pass before merge

Pattern: Follows backube/pvc-transfer _prowconfig.yaml — same setup (external org, no ci-operator jobs, branch protection via branchprotector).

Context: Part of Prow onboarding for shiftstack-qa. Prow plugin + Tide config already merged (#81862). This adds the branch protection layer.

Jira: OSPRH-32280

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 15, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2026
@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The Prow configuration for shiftstack/shiftstack-qa now protects the main branch and requires the ansible-lint status check.

Changes

Shiftstack QA branch protection

Layer / File(s) Summary
Configure main branch protection
core-services/prow/02_config/shiftstack/shiftstack-qa/_prowconfig.yaml
Adds branch protection for main with ansible-lint as a required status check.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only changes a Prow YAML config file; no Ginkgo tests or titles were added or modified.
Test Structure And Quality ✅ Passed Only a Prow config YAML changed; no Ginkgo test code or test patterns were modified.
Microshift Test Compatibility ✅ Passed Only a prowconfig YAML changed; no new Ginkgo e2e tests or MicroShift-incompatible APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a Prow YAML config changed; no new Ginkgo e2e tests were added, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only Prow branch-protection config changed; no deployment manifests, operators, or controllers were modified.
Ote Binary Stdout Contract ✅ Passed PR only edits Prow YAML branch-protection config; no OTE binary code or stdout-writing process hooks are changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only changes prow branch-protection YAML; no new Ginkgo e2e tests or network-sensitive code were added.
No-Weak-Crypto ✅ Passed The patch only adds Prow branch-protection YAML for shiftstack-qa; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto/comparison code appears.
Container-Privileges ✅ Passed The only changed file is a Prow config adding branch protection/Tide; it contains no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The only added content is Prow branch-protection YAML; it contains no logs, secrets, tokens, PII, or host/customer data.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the primary change: adding branch protection for shiftstack/shiftstack-qa.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: imatza-rh
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 15, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@imatza-rh: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@imatza-rh
imatza-rh marked this pull request as ready for review July 16, 2026 10:07
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2026
@openshift-ci
openshift-ci Bot requested review from gryf and mandre July 16, 2026 10:08
@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@imatza-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@imatza-rh

Copy link
Copy Markdown
Contributor Author

Closing - branch protection via branchprotector not needed. Prow plugin + Tide + require_self_approval: true (PR #81991) is sufficient.

@imatza-rh imatza-rh closed this Jul 16, 2026
@imatza-rh
imatza-rh deleted the shiftstack-qa-branch-protection branch July 16, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants