Require GH Actions checks, remove redundant Prow tests for velero + plugin forks

[kaovilai]

Summary

Adds required_status_checks.contexts to the branch-protection config for openshift/velero and its three plugin forks (velero-plugin-for-aws, velero-plugin-for-gcp, velero-plugin-for-microsoft-azure), and removes the now-redundant Prow-native unit-test/lint CI configs that duplicate the GitHub Actions checks being made required.

Today merges are gated only by tide's label requirements, not by any specific CI job passing — a PR can merge with failing GitHub Actions checks as long as labels are satisfied.

• openshift/velero: require ci/prow/images, Run CI, Run Linter Check
• plugin forks: require Run CI
• Removed redundant unit-test/lint ci-operator test entries (velero: all branches; plugin forks: all branches) — these duplicated the now-required Run CI/Run Linter Check GitHub Actions checks
• Removed ci/prow/lint from velero's required_status_checks since that Prow context no longer exists after the lint test removal

Fixes openshift/velero#552

Test plan

• make check-core / make checkconfig pass in CI
• Confirm listed context names match what GitHub currently reports on these repos
• Confirm removed ci/prow/unit-test / ci/prow/lint presubmits are no longer required anywhere

Note

Responses generated with Claude

Summary by CodeRabbit

• Updated Prow GitHub branch-protection configuration to ensure merges for openshift/velero depend on required CI status checks (ci/prow/images, Run CI, Run Linter Check) in addition to Tide label requirements.
• Updated branch-protection for the openshift/velero-plugin-for-aws, openshift/velero-plugin-for-gcp, and openshift/velero-plugin-for-microsoft-azure forks to require the Run CI status check.
• Removed redundant tests/Prow-native unit-test and lint job configuration from the CI/operator YAMLs for Velero and all three plugin forks (across OADP branches/versions and dev), including dropping the now-defunct ci/prow/lint required context.

[coderabbitai]

Walkthrough

Branch-protection configurations for Velero and three plugin forks now require specified CI status checks. OADP CI configurations remove redundant Prow unit-test and lint jobs and retain generated metadata and resource settings.

Changes

Velero CI alignment

Layer / File(s)	Summary
Require CI status checks core-services/prow/02_config/openshift/velero*/_prowconfig.yaml	The three plugin forks require Run CI; openshift/velero requires ci/prow/images, Run CI, and Run Linter Check.
Remove redundant Prow jobs ci-operator/config/openshift/velero*/...	OADP manifests remove optional unit-test and lint workflows, with generated metadata and top-level resource configuration remaining or being added.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

• openshift/velero#552 — Directly covers the required status checks and removal of duplicate Prow test/lint jobs.

Possibly related PRs

• openshift/release#81910 — Adds related required status checks to another repository’s Prow configuration.
• openshift/release#81948 — Adds a required status check to another OpenShift Prow configuration.

Suggested reviewers: danilo-gemoli, eemcmullan

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR adds required_status_checks for Velero and the three listed plugin forks, matching the linked issue's core requirement.
Out of Scope Changes check	✅ Passed	The removed ci-operator test blocks align with the linked issue's CI cleanup proposal, and no unrelated changes stand out.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	The commit only touches YAML config files (49 .yaml files) and no Go/Ginkgo test sources, so no test titles were added or changed.
Test Structure And Quality	✅ Passed	PR only changes YAML branch-protection/CI configs; no Ginkgo test code was modified, so the test-structure review is not applicable.
Microshift Test Compatibility	✅ Passed	Diff only changes YAML branch-protection and ci-operator configs; no new Ginkgo e2e test code or test bodies were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only YAML branch-protection/ci-operator config changed; no Go/Ginkgo e2e tests were added or modified, so SNO compatibility isn’t implicated.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The diff only updates prow/ci-operator YAML and removes test jobs; no deployment manifests, operators, or controllers were added or changed.
Ote Binary Stdout Contract	✅ Passed	PR changes only YAML/config files; no Go/JS/Python code or process-level stdout writes were touched.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The PR only edits YAML CI/branch-protection configs and removes test jobs; no new Ginkgo e2e test code or network/IP assumptions were added.
No-Weak-Crypto	✅ Passed	Touched files are only branch-protection/CI YAML; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons were found.
Container-Privileges	✅ Passed	Changed files are branch-protection/ci-operator YAML only; no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation fields found.
No-Sensitive-Data-In-Logs	✅ Passed	Only YAML config changed; no log statements or secret/PII-like strings were found in touched files.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: adding required checks and removing redundant Prow tests for Velero and its plugin forks.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@kaovilai: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[kaovilai]

/cc @openshift/team-openshift-oadp

[openshift-ci]

@kaovilai: GitHub didn't allow me to request PR reviews from the following users: openshift/team-openshift-oadp.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @openshift/team-openshift-oadp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[weshayutin]

/LGTM
THANK YOU @kaovilai!!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/velero/OWNERS [kaovilai,weshayutin]
• ci-operator/config/openshift/velero-plugin-for-aws/OWNERS [kaovilai]
• ci-operator/config/openshift/velero-plugin-for-gcp/OWNERS [kaovilai]
• ci-operator/config/openshift/velero-plugin-for-microsoft-azure/OWNERS [kaovilai]
• ci-operator/jobs/openshift/velero/OWNERS [kaovilai,weshayutin]
• ci-operator/jobs/openshift/velero-plugin-for-aws/OWNERS [kaovilai]
• ci-operator/jobs/openshift/velero-plugin-for-gcp/OWNERS [kaovilai]
• ci-operator/jobs/openshift/velero-plugin-for-microsoft-azure/OWNERS [kaovilai]
• core-services/prow/02_config/openshift/velero-plugin-for-aws/OWNERS [kaovilai]
• core-services/prow/02_config/openshift/velero-plugin-for-gcp/OWNERS [kaovilai]
• core-services/prow/02_config/openshift/velero-plugin-for-microsoft-azure/OWNERS [kaovilai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

@kaovilai: Updated the following 2 configmaps:

• config configmap in namespace ci at cluster core-ci using the following files:
  • key core-services-prow-02_config-openshift-velero-plugin-for-aws-_prowconfig.yaml using file core-services/prow/02_config/openshift/velero-plugin-for-aws/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-velero-plugin-for-gcp-_prowconfig.yaml using file core-services/prow/02_config/openshift/velero-plugin-for-gcp/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-velero-plugin-for-microsoft-azure-_prowconfig.yaml using file core-services/prow/02_config/openshift/velero-plugin-for-microsoft-azure/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-velero-_prowconfig.yaml using file core-services/prow/02_config/openshift/velero/_prowconfig.yaml
• config configmap in namespace ci at cluster app.ci using the following files:
  • key core-services-prow-02_config-openshift-velero-plugin-for-aws-_prowconfig.yaml using file core-services/prow/02_config/openshift/velero-plugin-for-aws/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-velero-plugin-for-gcp-_prowconfig.yaml using file core-services/prow/02_config/openshift/velero-plugin-for-gcp/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-velero-plugin-for-microsoft-azure-_prowconfig.yaml using file core-services/prow/02_config/openshift/velero-plugin-for-microsoft-azure/_prowconfig.yaml
  • key core-services-prow-02_config-openshift-velero-_prowconfig.yaml using file core-services/prow/02_config/openshift/velero/_prowconfig.yaml

Details

In response to this:

Summary

Adds required_status_checks.contexts to the branch-protection config for openshift/velero and its three plugin forks (velero-plugin-for-aws, velero-plugin-for-gcp, velero-plugin-for-microsoft-azure), and removes the now-redundant Prow-native unit-test/lint CI configs that duplicate the GitHub Actions checks being made required.

Today merges are gated only by tide's label requirements, not by any specific CI job passing — a PR can merge with failing GitHub Actions checks as long as labels are satisfied.

• openshift/velero: require ci/prow/images, Run CI, Run Linter Check
• plugin forks: require Run CI
• Removed redundant unit-test/lint ci-operator test entries (velero: all branches; plugin forks: all branches) — these duplicated the now-required Run CI/Run Linter Check GitHub Actions checks
• Removed ci/prow/lint from velero's required_status_checks since that Prow context no longer exists after the lint test removal

Fixes openshift/velero#552

Test plan

• make check-core / make checkconfig pass in CI
• Confirm listed context names match what GitHub currently reports on these repos
• Confirm removed ci/prow/unit-test / ci/prow/lint presubmits are no longer required anywhere

[!Note]
Responses generated with Claude

Summary by CodeRabbit

• Updated Prow GitHub branch-protection configuration to ensure merges for openshift/velero depend on required CI status checks (ci/prow/images, Run CI, Run Linter Check) in addition to Tide label requirements.
• Updated branch-protection for the openshift/velero-plugin-for-aws, openshift/velero-plugin-for-gcp, and openshift/velero-plugin-for-microsoft-azure forks to require the Run CI status check.
• Removed redundant tests/Prow-native unit-test and lint job configuration from the CI/operator YAMLs for Velero and all three plugin forks (across OADP branches/versions and dev), including dropping the now-defunct ci/prow/lint required context.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.