Skip to content

redhat-developer/rhdh-operator: update branch protection rules#81993

Merged
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
rm3l:rhdh-operator-branch-protection
Jul 16, 2026
Merged

redhat-developer/rhdh-operator: update branch protection rules#81993
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
rm3l:rhdh-operator-branch-protection

Conversation

@rm3l

@rm3l rm3l commented Jul 16, 2026

Copy link
Copy Markdown
Member

Add branch protection for release-1.9 and release-1.10, which are the current active release branches and need the same level of protection as main. Required status checks: PR Validate and Validate Bundle Manifests, along with required approving review.

Summary by CodeRabbit

Updates Prow branch protection for redhat-developer/rhdh-operator by requiring pull requests targeting main, release-1.9, and release-1.10 to be up to date before merging. The release branches also require validation checks (PR Validate and Validate Bundle Manifests) and approving reviews.

Add strict status checks to require PRs to be up-to-date before merging.
Add branch protection for release-1.9 and release-1.10 with PR Validate
and Validate Bundle Manifests as required status checks.

Assisted-by: Claude
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@rm3l, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fff3bbd7-fbe2-4c78-82c5-f08a87e6450d

📥 Commits

Reviewing files that changed from the base of the PR and between b1178ea and 4394cf1.

📒 Files selected for processing (1)
  • core-services/prow/02_config/redhat-developer/rhdh-operator/_prowconfig.yaml

Walkthrough

Branch protection configuration now enables strict required status checks for the main, release-1.9, and release-1.10 branches while retaining their existing status-check contexts.

Changes

RHDH Operator Branch Protection

Layer / File(s) Summary
Enable strict status checks
core-services/prow/02_config/redhat-developer/rhdh-operator/_prowconfig.yaml
Adds required_status_checks.strict: true to branch protection for main, release-1.9, and release-1.10.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a Prow config YAML changed; no test files or Ginkgo titles were added or modified.
Test Structure And Quality ✅ Passed PR only changes prow config; no Ginkgo test files or test code were modified, so the check is not applicable.
Microshift Test Compatibility ✅ Passed PR only changes a prow config YAML; no Ginkgo e2e tests or MicroShift-sensitive APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only _prowconfig.yaml changed; no Ginkgo e2e tests were added or modified, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only Prow branch-protection YAML changed; no deployment manifests, operator code, or scheduling constraints were modified.
Ote Binary Stdout Contract ✅ Passed Commit only changes a prow YAML config; no main/suite code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only _prowconfig.yaml changed; no Ginkgo/e2e tests were added, so the IPv6/disconnected-network check is not applicable.
No-Weak-Crypto ✅ Passed Changed YAML only updates branch protection; no weak crypto, custom crypto, or secret comparison code is present.
Container-Privileges ✅ Passed PR only changes Prow branch-protection YAML; no container/K8s manifests or privileged/root settings were added.
No-Sensitive-Data-In-Logs ✅ Passed Only branch-protection YAML changed; no log statements or sensitive-data strings were added.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the branch protection changes for redhat-developer/rhdh-operator.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2026
@rm3l

rm3l commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

/cc @subhashkhileri

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 16, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rm3l: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@subhashkhileri

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rm3l: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l, subhashkhileri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2026
@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@rm3l: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 6559c9e into openshift:main Jul 16, 2026
12 checks passed
@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@rm3l: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-redhat-developer-rhdh-operator-_prowconfig.yaml using file core-services/prow/02_config/redhat-developer/rhdh-operator/_prowconfig.yaml
  • config configmap in namespace ci at cluster core-ci using the following files:
    • key core-services-prow-02_config-redhat-developer-rhdh-operator-_prowconfig.yaml using file core-services/prow/02_config/redhat-developer/rhdh-operator/_prowconfig.yaml
Details

In response to this:

Add branch protection for release-1.9 and release-1.10, which are the current active release branches and need the same level of protection as main. Required status checks: PR Validate and Validate Bundle Manifests, along with required approving review.

Summary by CodeRabbit

Updates Prow branch protection for redhat-developer/rhdh-operator by requiring pull requests targeting main, release-1.9, and release-1.10 to be up to date before merging. The release branches also require validation checks (PR Validate and Validate Bundle Manifests) and approving reviews.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

SachinNinganure pushed a commit to SachinNinganure/release that referenced this pull request Jul 20, 2026
…hift#81993)

* redhat-developer/rhdh-operator: update branch protection rules

Add strict status checks to require PRs to be up-to-date before merging.
Add branch protection for release-1.9 and release-1.10 with PR Validate
and Validate Bundle Manifests as required status checks.

Assisted-by: Claude

* redhat-developer/rhdh-operator: drop strict status checks incompatible with Tide

Assisted-by: Claude

* Add 'Validate Dockerfile' to required status checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants