fix: update launchdarkly-js-sdk-common to 5.8.2#349
Merged
Conversation
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
@cursor review |
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
joker23
marked this pull request as ready for review
July 20, 2026 14:08
joker23
commented
Jul 20, 2026
| "typedoc": "^0.25.13", | ||
| "@types/estree": "^1.0.0" | ||
| "@types/estree": "^1.0.0", | ||
| "@types/node": "^20.0.0" |
Contributor
Author
There was a problem hiding this comment.
Needed to add this type dep to stop types/node from drifting to a higher major version level. Expected since this is an older sdk.
Contributor
There was a problem hiding this comment.
Exactly — pinned to ^20.0.0 to keep it within a major compatible with typescript ~5.4.5. Unpinned it had drifted to v26, which references lib types (IteratorObject, BuiltinIteratorReturn) not present in 5.4, breaking check-typescript (reproduces on a clean main).
keelerm84
approved these changes
Jul 20, 2026
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Picks up the bugfix released in
launchdarkly-js-sdk-commonv5.8.2 (https://github.com/launchdarkly/js-sdk-common).Describe the solution you've provided
Bump the
launchdarkly-js-sdk-commondependency from5.8.1to5.8.2.Uses
fix:(matching #341) so release-please cuts a patch release that propagates the fix to downstream consumers.Also pins
@types/nodeto^20.0.0.@types/nodewas previously unpinned (pulled transitively) and had floated to v26, which references lib types (IteratorObject,BuiltinIteratorReturn) that don't exist intypescript ~5.4.5, breakingnpm run check-typescript. This failure already exists onmain(verified on a clean checkout) and is unrelated to the common bump; the pin is the minimal fix to getcheck-typescript/ CI green again.Verified locally:
npm install,npm test(166 passed),npm run lint:all, andnpm run check-typescriptall pass.Describe alternatives you've considered
For the type errors,
skipLibCheckin tsconfig would also silence them, but pinning@types/nodeto a version compatible with the pinned TypeScript is more targeted.Additional context
Part of rolling out
launchdarkly-js-sdk-commonv5.8.2 across the client-side JS SDKs (companion PR innode-client-sdk). Downstream packages that depend on this SDK (react-client-sdk,vue-client-sdk,@launchdarkly/toolbar) will pick up the change transitively once this SDK is released.Link to Devin session: https://app.devin.ai/sessions/3ed6e570c11b4abb80724e0f2bc5f03e
Requested by: @joker23
Note
Low Risk
Dependency-only changes with no application logic edits; risk is limited to transitive behavior from the common SDK patch and dev-time typing.
Overview
Pulls in the 5.8.2 patch from
launchdarkly-js-sdk-common(replacing 5.8.1) so this browser SDK ships the upstream bugfix on the next patch release.Adds an explicit devDependency
@types/node:^20.0.0socheck-typescriptno longer fails when an unpinned transitive@types/node(e.g. v26) references lib types that TypeScript ~5.4.5 does not provide.Reviewed by Cursor Bugbot for commit ca4b27a. Bugbot is set up for automated code reviews on this repo. Configure here.