Skip to content

fix: update launchdarkly-js-sdk-common to 5.8.2#349

Merged
joker23 merged 2 commits into
mainfrom
devin/1784554979-bump-js-sdk-common-5.8.2
Jul 20, 2026
Merged

fix: update launchdarkly-js-sdk-common to 5.8.2#349
joker23 merged 2 commits into
mainfrom
devin/1784554979-bump-js-sdk-common-5.8.2

Conversation

@joker23

@joker23 joker23 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Requirements

  • I have added test coverage for new or changed functionality — n/a, dependency bump only
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Picks up the bugfix released in launchdarkly-js-sdk-common v5.8.2 (https://github.com/launchdarkly/js-sdk-common).

Describe the solution you've provided

Bump the launchdarkly-js-sdk-common dependency from 5.8.1 to 5.8.2.

-    "launchdarkly-js-sdk-common": "5.8.1"
+    "launchdarkly-js-sdk-common": "5.8.2"

Uses fix: (matching #341) so release-please cuts a patch release that propagates the fix to downstream consumers.

Also pins @types/node to ^20.0.0. @types/node was previously unpinned (pulled transitively) and had floated to v26, which references lib types (IteratorObject, BuiltinIteratorReturn) that don't exist in typescript ~5.4.5, breaking npm run check-typescript. This failure already exists on main (verified on a clean checkout) and is unrelated to the common bump; the pin is the minimal fix to get check-typescript / CI green again.

Verified locally: npm install, npm test (166 passed), npm run lint:all, and npm run check-typescript all pass.

Describe alternatives you've considered

For the type errors, skipLibCheck in tsconfig would also silence them, but pinning @types/node to a version compatible with the pinned TypeScript is more targeted.

Additional context

Part of rolling out launchdarkly-js-sdk-common v5.8.2 across the client-side JS SDKs (companion PR in node-client-sdk). Downstream packages that depend on this SDK (react-client-sdk, vue-client-sdk, @launchdarkly/toolbar) will pick up the change transitively once this SDK is released.

Link to Devin session: https://app.devin.ai/sessions/3ed6e570c11b4abb80724e0f2bc5f03e
Requested by: @joker23


Note

Low Risk
Dependency-only changes with no application logic edits; risk is limited to transitive behavior from the common SDK patch and dev-time typing.

Overview
Pulls in the 5.8.2 patch from launchdarkly-js-sdk-common (replacing 5.8.1) so this browser SDK ships the upstream bugfix on the next patch release.

Adds an explicit devDependency @types/node: ^20.0.0 so check-typescript no longer fails when an unpinned transitive @types/node (e.g. v26) references lib types that TypeScript ~5.4.5 does not provide.

Reviewed by Cursor Bugbot for commit ca4b27a. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
@joker23 joker23 self-assigned this Jul 20, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor

@cursor review

Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
@devin-ai-integration devin-ai-integration Bot changed the title chore: update launchdarkly-js-sdk-common to 5.8.2 fix: update launchdarkly-js-sdk-common to 5.8.2 Jul 20, 2026
@joker23
joker23 marked this pull request as ready for review July 20, 2026 14:08
@joker23
joker23 requested a review from a team as a code owner July 20, 2026 14:08

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Comment thread package.json
"typedoc": "^0.25.13",
"@types/estree": "^1.0.0"
"@types/estree": "^1.0.0",
"@types/node": "^20.0.0"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to add this type dep to stop types/node from drifting to a higher major version level. Expected since this is an older sdk.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly — pinned to ^20.0.0 to keep it within a major compatible with typescript ~5.4.5. Unpinned it had drifted to v26, which references lib types (IteratorObject, BuiltinIteratorReturn) not present in 5.4, breaking check-typescript (reproduces on a clean main).

@joker23
joker23 merged commit 29221e2 into main Jul 20, 2026
12 checks passed
@joker23
joker23 deleted the devin/1784554979-bump-js-sdk-common-5.8.2 branch July 20, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants