fix: update launchdarkly-js-client-sdk to 3.9.4#85
Open
joker23 wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Steven Zhang <szhang@launchdarkly.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
@cursor review |
joker23
marked this pull request as ready for review
July 20, 2026 20:53
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Propagates the
launchdarkly-js-sdk-commonv5.8.2 bugfix into the Vue SDK vialaunchdarkly-js-client-sdk3.9.4 (which was just released to pick up common 5.8.2 — launchdarkly/js-client-sdk#349).Describe the solution you've provided
Bump the exact-pinned
launchdarkly-js-client-sdkdependency from3.9.3to3.9.4.launchdarkly-js-client-sdk@3.9.4depends onlaunchdarkly-js-sdk-common@5.8.2, so this transitively pulls in the fix. Verified locally:npm install(resolves js-client-sdk 3.9.4 → common 5.8.2),npm test(22 passed),npm run lint, andnpm run check-typescriptall pass.Describe alternatives you've considered
Leaving the pin as-is — rejected, since the exact pin (
3.9.3) would otherwise never pick up the released fix.Additional context
Part of rolling out
launchdarkly-js-sdk-commonv5.8.2 across the client-side JS SDKs. Companion PRs: js-client-sdk#349 (merged), node-client-sdk#72 (merged), electron-client-sdk (separate).Link to Devin session: https://app.devin.ai/sessions/3ed6e570c11b4abb80724e0f2bc5f03e
Requested by: @joker23
Note
Low Risk
Single dependency version bump with no application code changes; risk is limited to behavior in the transitive client SDK/common packages.
Overview
Dependency-only change: the exact pin on
launchdarkly-js-client-sdkmoves from3.9.3to3.9.4inpackage.json.That release pulls in
launchdarkly-js-sdk-common@5.8.2, propagating the upstream bugfix into the Vue SDK without any Vue binding or source changes in this repo.Reviewed by Cursor Bugbot for commit 992de0f. Bugbot is set up for automated code reviews on this repo. Configure here.