Skip to content

fix: update launchdarkly-js-sdk-common to 5.8.2 #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joker23 merged 2 commits into from
Jul 20, 2026
Merged

fix: update launchdarkly-js-sdk-common to 5.8.2 #349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72fd6b6
chore: update launchdarkly-js-sdk-common to 5.8.2
devin-ai-integration[bot] Jul 20, 2026
ca4b27a
fix: pin @types/node to ^20 for compatibility with typescript 5.4
devin-ai-integration[bot] Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,12 @@
"sinon": "^14.0.0",
"typescript": "~5.4.5",
"typedoc": "^0.25.13",
"@types/estree": "^1.0.0"
"@types/estree": "^1.0.0",
"@types/node": "^20.0.0"

@joker23 joker23 Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to add this type dep to stop types/node from drifting to a higher major version level. Expected since this is an older sdk.

@devin-ai-integration devin-ai-integration Bot Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly — pinned to ^20.0.0 to keep it within a major compatible with typescript ~5.4.5. Unpinned it had drifted to v26, which references lib types (IteratorObject, BuiltinIteratorReturn) not present in 5.4, breaking check-typescript (reproduces on a clean main).

},
"dependencies": {
"escape-string-regexp": "^4.0.0",
"launchdarkly-js-sdk-common": "5.8.1"
"launchdarkly-js-sdk-common": "5.8.2"
},
"repository": {
"type": "git",
Expand Down
Loading