-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Make automatic PhysX defaults concrete and fix install hints #6849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kellyguo11
merged 11 commits into
isaac-sim:develop
from
kellyguo11:kellyguo11/fix-ovphysx-install-hint
Aug 4, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
985c4f8
Fix backend defaults and install guidance
kellyguo11 78706ab
Document OvPhysX preset configuration
kellyguo11 ef48350
Preserve explicit Newton task defaults
kellyguo11 3c5745b
Correct RL framework extra guidance
kellyguo11 2fe507a
Fix concrete PhysX guard guidance
kellyguo11 e997f0e
Clarify Reach migration default
kellyguo11 51324af
Merge branch 'develop' into kellyguo11/fix-ovphysx-install-hint
kellyguo11 b71ff32
Stabilize OvPhysX root velocity test
kellyguo11 ace9a6b
Merge upstream develop
kellyguo11 41fc1a8
Clarify automatic PhysX selection
kellyguo11 ccb31a7
Merge upstream develop
kellyguo11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 Suggestion · Design Architecture — Migration recipe flips default to Newton
This "Adding Multi-Backend Support" recipe has a Before of
self.sim.physics = PhysxCfg(bounce_threshold_velocity=0.2), so addingdefault: NewtonCfg = newton_mjwarpteaches readers that the migration silently changes their default backend to Newton. It also contradicts the generic example earlier in the same page (default: PhysxCfg = isaacsim_physx). Useisaacsim_physxhere, or state explicitly that this task intentionally keeps a Newton default.