Skip to content

Add the simready-search dependency - #999

Merged
xyao-nv merged 2 commits into
mainfrom
xyao/chore/simready_search_deps
Aug 3, 2026
Merged

Add the simready-search dependency#999
xyao-nv merged 2 commits into
mainfrom
xyao/chore/simready_search_deps

Conversation

@xyao-nv

@xyao-nv xyao-nv commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add the simready-search dependency, to unblock #982 testing.

Detailed description

  • Override boto3, botocore, requests and s3transfer to the versions isaacsim-kernel pins. simready-search asks for boto3==1.42.58, requests>=2.32.5 and s3transfer 0.16.x, all over-strict; without the overrides it does not resolve alongside either sim-stack flavor.

@xyao-nv
xyao-nv marked this pull request as ready for review July 31, 2026 22:26
@arena-review-bot

Copy link
Copy Markdown
Contributor

🤖 Isaac Lab-Arena Review Bot

Summary

Adds simready-search to the dev extra and pins the AWS/HTTP stack (boto3, botocore, requests, s3transfer) via global override-dependencies so the wheel resolves alongside both sim-stack flavors. The change is small, and the non-obvious dependency-resolution reasoning is documented inline and in the commit message. The uv.lock diff confirms these four packages were already locked at exactly the pinned versions, so the overrides only stop simready-search from bumping them — the default (non-dev) install path is unchanged.

Notes for human reviewers

This is an infra/dependency change, so worth a deliberate confirmation rather than a rubber stamp:

  • The override-dependencies are global (uv cannot scope them to the dev extra), so a dev-only dependency now caps requests/boto3 for every flavor. This is harmless here because the pins match what isaacsim-kernel already resolves — but it means CI must confirm both isaaclab-from-wheel and isaaclab-from-source still lock cleanly. The "Detect uv-related changes" check covers this; make sure it goes green before merge.
  • Placing simready-search in dev (alongside the review GUI) rather than its own extra is a documented judgment call — reasonable given the asset search is coupled to that GUI.

No code correctness, boundary, or silent-failure concerns.

Verdict

Ship it (pending the uv-resolution CI check passing).

@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds simready-search to the development dependency set and updates the uv resolution with Isaac Sim-compatible AWS/HTTP overrides.

  • Adds simready-search 2026.4.2 from NVIDIA's package index.
  • Overrides boto3, botocore, requests, and s3transfer in uv.
  • Regenerates uv.lock for both supported simulator-stack flavors.

Confidence Score: 4/5

The Docker dependency path needs equivalent pip constraints before this PR is safe to merge.

Native uv installs retain the intended Isaac Sim dependency versions, but the Docker build installs the same dev extra through pip, which ignores those overrides and can replace the simulator-pinned AWS/HTTP stack.

Files Needing Attention: pyproject.toml and docker/Dockerfile.isaaclab_arena

Important Files Changed

Filename Overview
pyproject.toml Adds simready-search and uv-only compatibility overrides, but leaves the pip-based Docker installation without equivalent constraints.
uv.lock Records simready-search and the intended AWS/HTTP override resolution for native uv environments.

Reviews (1): Last reviewed commit: "Add the simready-search dependency" | Re-trigger Greptile

Comment thread pyproject.toml
Declares the SimReady asset-search client the agentic environment
generation uses to look up props the Arena asset registry does not cover.

- Put in the dev extra rather than an extra of its own: it adds a single
  wheel, since Isaac Sim already brings everything it depends on, and a
  separate extra only bought a way to install the review GUI with its
  asset search missing.
- Override boto3, botocore, requests and s3transfer to the versions
  isaacsim-kernel pins. simready-search asks for boto3==1.42.58,
  requests>=2.32.5 and s3transfer 0.16.x, all over-strict; without the
  overrides uv cannot resolve it alongside either sim-stack flavor.
- Apply the same pins by hand in the Docker image. pip has no override
  mechanism, and it installs into a directory that precedes Isaac Sim's
  prebundle on sys.path, so the image would otherwise run its S3 asset
  searches against an AWS stack Isaac Sim does not ship.

Signed-off-by: Xinjie Yao <xyao@nvidia.com>
@xyao-nv
xyao-nv force-pushed the xyao/chore/simready_search_deps branch from e801ade to 3fa7d75 Compare August 1, 2026 06:00
@xyao-nv
xyao-nv merged commit ca36816 into main Aug 3, 2026
11 checks passed
qianl-nv pushed a commit that referenced this pull request Aug 3, 2026
## Summary

Fix post-merge image build broken by SimReady pkg pip 

## Detailed description
- #999 listed simready-search==0.2.1, but pypi.nvidia.com carries only
2026.4.2. The pin was a leftover, so the post-merge image build died at
that layer.
- Fix: dropped the re-pin and used the version in [dev] as the single
source of truth.

---------

Signed-off-by: Xinjie Yao <xyao@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants