Add the simready-search dependency - #999
Conversation
🤖 Isaac Lab-Arena Review BotSummaryAdds Notes for human reviewersThis is an infra/dependency change, so worth a deliberate confirmation rather than a rubber stamp:
No code correctness, boundary, or silent-failure concerns. VerdictShip it (pending the uv-resolution CI check passing). |
Greptile SummaryAdds simready-search to the development dependency set and updates the uv resolution with Isaac Sim-compatible AWS/HTTP overrides.
Confidence Score: 4/5The Docker dependency path needs equivalent pip constraints before this PR is safe to merge. Native uv installs retain the intended Isaac Sim dependency versions, but the Docker build installs the same dev extra through pip, which ignores those overrides and can replace the simulator-pinned AWS/HTTP stack. Files Needing Attention: pyproject.toml and docker/Dockerfile.isaaclab_arena Important Files Changed
Reviews (1): Last reviewed commit: "Add the simready-search dependency" | Re-trigger Greptile |
Declares the SimReady asset-search client the agentic environment generation uses to look up props the Arena asset registry does not cover. - Put in the dev extra rather than an extra of its own: it adds a single wheel, since Isaac Sim already brings everything it depends on, and a separate extra only bought a way to install the review GUI with its asset search missing. - Override boto3, botocore, requests and s3transfer to the versions isaacsim-kernel pins. simready-search asks for boto3==1.42.58, requests>=2.32.5 and s3transfer 0.16.x, all over-strict; without the overrides uv cannot resolve it alongside either sim-stack flavor. - Apply the same pins by hand in the Docker image. pip has no override mechanism, and it installs into a directory that precedes Isaac Sim's prebundle on sys.path, so the image would otherwise run its S3 asset searches against an AWS stack Isaac Sim does not ship. Signed-off-by: Xinjie Yao <xyao@nvidia.com>
e801ade to
3fa7d75
Compare
## Summary Fix post-merge image build broken by SimReady pkg pip ## Detailed description - #999 listed simready-search==0.2.1, but pypi.nvidia.com carries only 2026.4.2. The pin was a leftover, so the post-merge image build died at that layer. - Fix: dropped the re-pin and used the version in [dev] as the single source of truth. --------- Signed-off-by: Xinjie Yao <xyao@nvidia.com>
Summary
Add the simready-search dependency, to unblock #982 testing.
Detailed description