Skip to content

Fix post-merge image build broken by SimReady pkg - #1001

Merged
qianl-nv merged 2 commits into
mainfrom
xyao/fix/simready_search_pin
Aug 3, 2026
Merged

Fix post-merge image build broken by SimReady pkg#1001
qianl-nv merged 2 commits into
mainfrom
xyao/fix/simready_search_pin

Conversation

@xyao-nv

@xyao-nv xyao-nv commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix post-merge image build broken by SimReady pkg pip

Detailed description

  • Add the simready-search dependency #999 listed simready-search==0.2.1, but pypi.nvidia.com carries only 2026.4.2. The pin was a leftover, so the post-merge image build died at that layer.
  • Fix: dropped the re-pin and used the version in [dev] as the single source of truth.

The Docker image build hand-applies the [tool.uv] override-dependencies with a
--force-reinstall --no-deps pip call, and that call also pinned
simready-search==0.2.1 -- a version that does not exist on pypi.nvidia.com,
which carries 2026.4.2 only. The build failed at that step on main.

simready-search is already installed by the preceding "pip install -e .[dev]",
so drop it from the override call and let pyproject.toml's
simready-search>=2026.4.2 be its only version declaration.

Signed-off-by: Xinjie Yao <xyao@nvidia.com>
@xyao-nv
xyao-nv marked this pull request as ready for review August 3, 2026 05:56
@arena-review-bot

Copy link
Copy Markdown
Contributor

🤖 Isaac Lab-Arena Review Bot

Summary

This PR drops a stale simready-search==0.2.1 pin from the Dockerfile's hand-applied --force-reinstall --no-deps step, which was breaking the post-merge image build because that version does not exist on pypi.nvidia.com (only 2026.4.2 is published). simready-search is already installed by the preceding pip install -e .[dev] (declared as >=2026.4.2 in pyproject.toml), so removing the re-pin leaves pyproject.toml as the single source of truth. Verified against pyproject.toml: simready-search is not part of override-dependencies, and the remaining force-reinstalled packages (boto3/botocore/s3transfer/requests) still match the AWS/HTTP stack overrides — the fix is correct and minimal.

Test Coverage

Not applicable — this is a Docker build fix; the post-merge image build itself is the validating check.

Verdict

Ship it

@greptile-apps

greptile-apps Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes the base image build by removing an obsolete, unavailable simready-search==0.2.1 reinstall and relying on the version declared by the project’s dev extra.

  • Keeps pyproject.toml as the single source of truth for simready-search.
  • Retains the explicit AWS and requests dependency overrides required by Isaac Sim.

Confidence Score: 5/5

The PR appears safe to merge, with the obsolete package reinstall removed while the package remains installed through the existing development extra.

The editable development installation already declares simready-search at the available version, and the subsequent command continues to enforce the Isaac Sim-compatible boto3, botocore, s3transfer, and requests versions.

Important Files Changed

Filename Overview
docker/Dockerfile.isaaclab_arena Removes a redundant invalid package pin while preserving the Docker image’s intentional dependency compatibility overrides.

Reviews (1): Last reviewed commit: "Fix post-merge image build broken by a s..." | Re-trigger Greptile

@qianl-nv
qianl-nv merged commit bc03976 into main Aug 3, 2026
15 of 20 checks passed
@qianl-nv
qianl-nv deleted the xyao/fix/simready_search_pin branch August 3, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants