Fix post-merge image build broken by SimReady pkg - #1001
Conversation
The Docker image build hand-applies the [tool.uv] override-dependencies with a --force-reinstall --no-deps pip call, and that call also pinned simready-search==0.2.1 -- a version that does not exist on pypi.nvidia.com, which carries 2026.4.2 only. The build failed at that step on main. simready-search is already installed by the preceding "pip install -e .[dev]", so drop it from the override call and let pyproject.toml's simready-search>=2026.4.2 be its only version declaration. Signed-off-by: Xinjie Yao <xyao@nvidia.com>
🤖 Isaac Lab-Arena Review BotSummaryThis PR drops a stale Test CoverageNot applicable — this is a Docker build fix; the post-merge image build itself is the validating check. VerdictShip it |
Greptile SummaryThis PR fixes the base image build by removing an obsolete, unavailable
Confidence Score: 5/5The PR appears safe to merge, with the obsolete package reinstall removed while the package remains installed through the existing development extra. The editable development installation already declares simready-search at the available version, and the subsequent command continues to enforce the Isaac Sim-compatible boto3, botocore, s3transfer, and requests versions. Important Files Changed
Reviews (1): Last reviewed commit: "Fix post-merge image build broken by a s..." | Re-trigger Greptile |
Summary
Fix post-merge image build broken by SimReady pkg pip
Detailed description