Fix text2text generation_kwargs leaking across compute calls - #796
Open
tonycoder-hub wants to merge 1 commit into
Open
Fix text2text generation_kwargs leaking across compute calls#796tonycoder-hub wants to merge 1 commit into
tonycoder-hub wants to merge 1 commit into
Conversation
Text2TextGenerationEvaluator.compute() updated the class attribute PIPELINE_KWARGS in place, so generation_kwargs passed to one call kept being forwarded to the pipeline on every later call and on every other instance of the evaluator. Co-authored-by: Tony Coder <407243179@qq.com>
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Text2TextGenerationEvaluator.compute()didself.PIPELINE_KWARGS.update(generation_kwargs).PIPELINE_KWARGSis a class attribute, so kwargs from onecompute()leaked into later calls, including on a freshly constructed evaluator.SummarizationEvaluatorandTranslationEvaluatorinherit the same leak.Build a per-call dict from the class defaults instead of mutating them.
Distinct from #794/#795. Not the same as #775 (task validation) or #754 (proposal to delete these evaluators).
Tests
python -m pytest tests/test_evaluator.py -k Text2Text -v→ 7 passed, 1 skipped (new test failed on main).python -m pytest tests/test_evaluator.py→ 43 passed, 14 skipped.