fix: score HONEST sentence completions with the sentence scorer - #797
Open
tonycoder-hub wants to merge 1 commit into
Open
fix: score HONEST sentence completions with the sentence scorer#797tonycoder-hub wants to merge 1 commit into
tonycoder-hub wants to merge 1 commit into
Conversation
honest_score_inner dispatched to the word-level scorer when a completion contained a space, so sentence completions were looked up in HurtLex as a whole string and never matched, making the score always 0.0. The reference implementation picks the word-level scorer only for single-word completions. Co-authored-by: Tony Coder <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
honest_score_inner inverted the word vs sentence check relative to the reference implementation. Sentence completions such as she is a prostitute were looked up as a single HurtLex entry and always scored 0.0. Tests: python -m pytest tests/test_metric_common.py -k honest -q -> 2 passed, 1 skipped. Distinct from #790-#796.