fix: treat sentiment-analysis and text-classification as the same evaluator task - #798
Open
tonycoder-hub wants to merge 1 commit into
Open
Conversation
`evaluator("sentiment-analysis")` rejected a `text-classification` pipeline (and
vice versa) because `prepare_pipeline` compared the raw task strings, even though
`sentiment-analysis` is a documented alias of `text-classification`. Resolve both
task names through `transformers`' `TASK_ALIASES` before comparing them.
Co-authored-by: Tony Coder <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transformers treats sentiment-analysis as an alias of text-classification (and ner of token-classification). evaluate documents evaluator("sentiment-analysis") as supported, but prepare_pipeline compared the raw task strings, so a text-classification pipeline passed to evaluator("sentiment-analysis") raised ValueError.
Both sides are now resolved through transformers TASK_ALIASES before comparing.
Tests: python3 -m pytest tests/test_evaluator.py::TestTextClassificationEvaluator -q — 8 passed, 2 skipped. Distinct from #790-#797.