fix: stop ASR generation_kwargs leaking across compute calls - #799
Open
tonycoder-hub wants to merge 1 commit into
Open
fix: stop ASR generation_kwargs leaking across compute calls#799tonycoder-hub wants to merge 1 commit into
tonycoder-hub wants to merge 1 commit into
Conversation
AutomaticSpeechRecognitionEvaluator.compute updated the class-level PIPELINE_KWARGS dict in place, so generation_kwargs from one call were still passed to the pipeline on every later call and on every other evaluator instance. Build a per-call copy instead. Co-authored-by: Tony Coder <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutomaticSpeechRecognitionEvaluator.compute called self.PIPELINE_KWARGS.update(generation_kwargs). PIPELINE_KWARGS is a class attribute, so kwargs from one compute leaked into later calls and other instances. Same leak #796 fixed for text2text.
Now rebinds an instance-level copy per call.
Tests: python -m pytest tests/test_evaluator.py -q — 43 passed, 14 skipped. Distinct from #790-#798.