Skip to content

feat(studies): add spatial normal-electorate accumulators (split 1/3 of #56) - #81

Open
endolith wants to merge 1 commit into
cursor/issue-10-simulation-api-44e5from
skales/split-1-spatial-accumulators
Open

feat(studies): add spatial normal-electorate accumulators (split 1/3 of #56)#81
endolith wants to merge 1 commit into
cursor/issue-10-simulation-api-44e5from
skales/split-1-spatial-accumulators

Conversation

@endolith

@endolith endolith commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Split 1 of 3 from #56, per the plan in #80 and the comment on #52.

Adds accumulate_spatial_condorcet_by_ncands and accumulate_spatial_sue_by_ncands to a new elsim/studies/spatial_normal.py, factoring out the nested for each election: for each n_cands: loop shared by Merrill-style figures (2.c/2.d and 4.a/4.b). Wires them into elsim/studies/__init__.py.

Stacked on top of #52's branch (cursor/issue-10-simulation-api-44e5) so it lands after the studies API itself. No behavior changes; purely additive.

Add accumulate_spatial_condorcet_by_ncands and accumulate_spatial_sue_by_ncands,
factoring out the nested for-each-election / for-each-n_cands loop shared by
Merrill-style figures (2.c/2.d, 4.a/4.b). Declarative method maps turn example
driver loops into one-liners. Split out of #56 so it can land independently on
top of #52.
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5b03db18-73b9-484b-a132-08c511ebf552

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant