Skip to content

feat(studies): use approval_at_optimal in Merrill tables 1/2/4 (split 3/3 of #56) - #84

Open
endolith wants to merge 2 commits into
cursor/issue-10-simulation-api-44e5from
skales/split-3-merrill-tables
Open

feat(studies): use approval_at_optimal in Merrill tables 1/2/4 (split 3/3 of #56)#84
endolith wants to merge 2 commits into
cursor/issue-10-simulation-api-44e5from
skales/split-3-merrill-tables

Conversation

@endolith

@endolith endolith commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Split 3 of 3 from #56, per the plan in #80. Stacked on #82 (base: cursor/issue-10-simulation-api-44e5), sibling of #81 and #82.

Problem: merrill_1984_table_1_fig_1.py, merrill_1984_table_2.py, and merrill_1984_table_4.py still build ranked_methods/rated_methods from the shared merrill_1984_comparison_methods() helper, which hardcodes the Merrill method set.

Approach: define the method dicts locally in each table script, importing the methods directly and using the new public approval_at_optimal helper for the Approval entry — the same inline pattern already used by the _updated fig scripts (2c/2d, 4a/4b) and table 3. This removes the last hardcoded-Merrill dependency from the table scripts.

merrill_1984_comparison_methods stays in condorcet_metrics.py because the non-updated fig_2c_2d.py and fig_4a_4b.py still use it.

Commits:

  • f8f4f8d feat(studies): define Merrill tables 1/2/4 methods locally with approval_at_optimal

Skales

…elper

Rename the private _approval_at_optimal wrapper to public approval_at_optimal
with a default tiebreaker, so scripts can reference it directly in rated_methods
mappings instead of repeating a lambda. Split 2 of 3 from #56, stacked on #52.
Tables 1, 2, and 4 pull ranked/rated methods from the shared
merrill_1984_comparison_methods() helper. Define the method dicts inline in
each script instead, matching the pattern already used by the _updated fig
scripts, so tables no longer depend on the shared helper.

merrill_1984_comparison_methods() stays for the non-updated fig scripts.
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 34faae53-208d-47b0-9707-4206b40ae799

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant