feat(studies): use approval_at_optimal in Merrill tables 1/2/4 (split 3/3 of #56) - #84
Open
endolith wants to merge 2 commits into
Open
Conversation
Tables 1, 2, and 4 pull ranked/rated methods from the shared merrill_1984_comparison_methods() helper. Define the method dicts inline in each script instead, matching the pattern already used by the _updated fig scripts, so tables no longer depend on the shared helper. merrill_1984_comparison_methods() stays for the non-updated fig scripts.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split 3 of 3 from #56, per the plan in #80. Stacked on #82 (base:
cursor/issue-10-simulation-api-44e5), sibling of #81 and #82.Problem:
merrill_1984_table_1_fig_1.py,merrill_1984_table_2.py, andmerrill_1984_table_4.pystill buildranked_methods/rated_methodsfrom the sharedmerrill_1984_comparison_methods()helper, which hardcodes the Merrill method set.Approach: define the method dicts locally in each table script, importing the methods directly and using the new public
approval_at_optimalhelper for the Approval entry — the same inline pattern already used by the_updatedfig scripts (2c/2d, 4a/4b) and table 3. This removes the last hardcoded-Merrill dependency from the table scripts.merrill_1984_comparison_methodsstays incondorcet_metrics.pybecause the non-updatedfig_2c_2d.pyandfig_4a_4b.pystill use it.Commits:
f8f4f8dfeat(studies): define Merrill tables 1/2/4 methods locally with approval_at_optimal— Skales