feat(studies): add approval_at_optimal rated-method helper (split 2/3 of #56) - #82
Open
endolith wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split 2 of 3 from #56, stacked on #52 (base:
cursor/issue-10-simulation-api-44e5), sibling of #81.Problem:
rated_methodsmappings repeat the same lambda (approval(approval_optimal(utilities), tiebreaker)) in every Merrill-style script.Approach: promote the private
_approval_at_optimalwrapper to publicapproval_at_optimal(utilities, tiebreaker="random"), add a docstring, export it fromelsim.studies, and switchmerrill_1984_comparison_methodsto use it. Existing tests cover it throughmerrill_1984_comparison_methods.Commits:
b4f56e2feat(studies): promote approval_at_optimal to a public rated-method helperAlso drops a stray backslash in a
condorcet_metricsdocstring while in the file.— Skales