Skip to content

feat(studies): add approval_at_optimal rated-method helper (split 2/3 of #56) - #82

Open
endolith wants to merge 1 commit into
cursor/issue-10-simulation-api-44e5from
skales/split-2-approval-helper
Open

feat(studies): add approval_at_optimal rated-method helper (split 2/3 of #56)#82
endolith wants to merge 1 commit into
cursor/issue-10-simulation-api-44e5from
skales/split-2-approval-helper

Conversation

@endolith

@endolith endolith commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Split 2 of 3 from #56, stacked on #52 (base: cursor/issue-10-simulation-api-44e5), sibling of #81.

Problem: rated_methods mappings repeat the same lambda (approval(approval_optimal(utilities), tiebreaker)) in every Merrill-style script.

Approach: promote the private _approval_at_optimal wrapper to public approval_at_optimal(utilities, tiebreaker="random"), add a docstring, export it from elsim.studies, and switch merrill_1984_comparison_methods to use it. Existing tests cover it through merrill_1984_comparison_methods.

Commits:

  • b4f56e2 feat(studies): promote approval_at_optimal to a public rated-method helper

Also drops a stray backslash in a condorcet_metrics docstring while in the file.

Skales

…elper

Rename the private _approval_at_optimal wrapper to public approval_at_optimal
with a default tiebreaker, so scripts can reference it directly in rated_methods
mappings instead of repeating a lambda. Split 2 of 3 from #56, stacked on #52.
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b52f3c6c-a70e-4f65-b0f2-ab6edf2fd139

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant