Show only the transfer rows that fit, instead of demanding all fourteen#68
Merged
Conversation
The panel asked for 267 dialog units of height whatever the screen offered, and the form view scrolled when it could not have them. On a 1280x800 display at 125% that is taller than the client area even maximized, so the wizard buttons sat below the fold behind a scrollbar from the first launch. Size the template for eight rows and let the rest appear as the panel grows. The grid now works out how many rows fit the current height, hides the others, and closes the Actions frame under the last one on screen. The spacing comes from the template at run time rather than from hardcoded dialog units, so it holds at any DPI. Row visibility had two writers, this and the Actions checkbox, so the checkbox now goes through the same helper rather than showing rows that do not fit. Its comments claimed ModifyStyle's arguments were the other way round; corrected while here. Needs an eye on a VM: CI cannot see layout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019HXNEMWtyrkW7xoD8ewcR3 Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The panel asked for 267 dialog units of height whatever the screen offered, and the form view scrolled when it could not have them. On a 1280x800 display at 125% scaling that exceeds the client area even maximized, so the wizard buttons sat below the fold behind a scrollbar from the very first launch.
The template is now sized for eight rows and the rest appear as the panel grows. The grid works out how many rows fit the current height, hides the others, and closes the Actions frame under the last one on screen. Spacing is measured from the template at run time rather than hardcoded in dialog units, so it holds at any DPI.
Row visibility had two writers, this and the Actions checkbox, so the checkbox now goes through the same helper instead of showing rows that do not fit. Its comments had
ModifyStylearguments backwards, corrected while there.Independent of #65: no shared files, and this measures the page own geometry rather than the sheet, which is what #65 changes.
CI cannot see layout, so this wants a look on the VM. Worth checking both directions: a small window should drop rows rather than scroll, and a large one should show all fourteen.