Give the restored window a sensible default size#69
Merged
Conversation
The frame starts maximized, and on a first run nothing ever set its restored rectangle, so it kept the CW_USEDEFAULT one MFC created it with. Un-maximizing therefore dropped to a small window on any screen, large ones included, and the panel gained scrollbars it had no reason to need. Set the restored rectangle to three quarters of the work area, centred, before maximizing. It scales with the display instead of being a fixed guess, and it only applies when there is no saved placement to honour. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019HXNEMWtyrkW7xoD8ewcR3 Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frame starts maximized, and on a first run nothing ever set its restored rectangle, so it kept the
CW_USEDEFAULTone MFC created it with. Un-maximizing therefore dropped to a small window on any display, large ones included, and the panel gained scrollbars it had no reason to need.Sets the restored rectangle to three quarters of the work area, centred, before maximizing. That scales with the screen rather than being a fixed guess, and it only applies when there is no saved placement to honour, so it never overrides a size the user has chosen.
Reported from VM testing, where un-maximizing showed scrollbars regardless of resolution. Pairs with #68, which cut what the panel demands in the first place.