Fix offset-only aggregate queries - #2
Draft
wtsnz wants to merge 1 commit into
Draft
Conversation
Problem: Aggregate queries were wrapped only for `distinct` or `limit`. An ordered query with only an offset could therefore aggregate the wrong input set because the offset was not applied inside the aggregate subquery. Change: Wrap offset-only inputs in all three aggregate-query paths and preserve ordering whenever a limit or offset depends on it. Continue removing irrelevant ordering when no row-selection operator requires it. Provenance: This is an existing AshSQL lateral-query defect discovered while reviewing the grouped aggregate extraction. It is intentionally isolated from the grouped feature branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Aggregate queries were wrapped only when they used
distinctorlimit. An ordered query with an offset but no limit could aggregate the wrong input set because the offset was not applied inside the aggregate subquery.This is an existing AshSQL lateral-query defect that we found while we reviewed the grouped aggregate extraction. This fix is separate from the grouped strategy PR.
Impact
Root query aggregates now apply offset-only row selection before aggregation.
Regression coverage
The Postgres regression is in wtsnz/ash_postgres#1.
Validation
mix format --check-formattedmix test— 1 test passedwtsnz/ash_postgres:test/lateral-offset-only-aggregatesbranch.