Test offset-only aggregate queries - #1
Draft
wtsnz wants to merge 1 commit into
Draft
Conversation
Problem: The shared AshSQL lateral query path did not wrap an aggregate input that had an offset without a limit. Postgres coverage did not distinguish the offset result set from the full ordered input. Change: Create three ordered posts, offset the first post, and assert that the aggregate count sees only the remaining two records. Provenance: This regression covers an existing AshSQL bug and depends on the `fix/lateral-offset-only-aggregates` follow-up branch. It is separate from the grouped aggregate extraction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The shared AshSQL lateral query path did not wrap aggregate inputs that had an offset and no limit. Postgres had no coverage that distinguished the offset row set from the full ordered input.
Dependency
This test depends on wtsnz/ash_sql#2. It is separate from the grouped aggregate extraction.
Validation
mix format --check-formattedMIX_ENV=test ASH_SQL_VERSION=local mix test test/aggregate_test.exs:29