Editor toolbar: home glyph only, edit shortcuts, full-bleed bar (SDK 0.79.0) - #44
Merged
Merged
Conversation
…0.79.0) Three changes to what the bar does with an image open, all still gated on `hasImages` so the landing view is untouched. The product name is gone. SDK 0.79.0's `onHome` now replaces the whole identity with a single home glyph rather than keeping the logo and name and swapping the chevron — Universal PDF's open-document toolbar has no branding either. Mid-edit you know which product you are in. The bar goes full-bleed. The editor is full-bleed — thumbnail sidebar hard against the left edge, resize panel against the right — so a centred max-w-7xl navbar floated inset above it. New EDITOR_CONTAINER spans the viewport, which is what puts the home button at the far left and the actions/profile/changelog cluster at the far right, in line with the editor beneath. The brand claim becomes quick edits. "100% Open Source (FREE)" is right on a landing page and dead weight over an open image, so the SDK's new `centre` slot carries background removal and face blur instead — the two features that are one click from useful with no configuration and otherwise several scrolls down the side panel. Deliberately a shortcut layer, not a second home: every one of them still lives in the panel with its full controls. Hidden below lg, where the panel is the whole screen and half a toolbar is worse than none. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015TVwu9Zr3bL9vQDfAcEroy
The previous commit's lock paired version 0.79.0 with 0.78.0's integrity hash. `npm ci` did not fail on that — it matched the hash against its cache and quietly installed the 0.78.0 tarball into the 0.79.0 slot, so the build then type-errored on `centre` not existing. Verified properly this time: `npm ci` from an empty node_modules installs 0.79.0, and the app builds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015TVwu9Zr3bL9vQDfAcEroy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #43, which branched off the pre-squash history of #42 and so conflicted with
main. Same two commits, rebased ontomain; rebuilt and re-verified after the rebase.Three changes to what the bar does with an image open, all gated on
hasImagesso the landing view is untouched.The product name is gone
SDK 0.79.0's
onHomenow replaces the whole identity with a single home glyph, where 0.78.0 kept the logo and name and only swapped the switcher's chevron. Universal PDF's open-document toolbar has no branding either — mid-edit you know which product you're in, and the name is dead weight where an editor needs the room.The bar goes full-bleed
The editor is full-bleed — thumbnail sidebar hard against the left edge, resize panel against the right — so a centred
max-w-7xlnavbar floated inset above it. NewEDITOR_CONTAINERspans the viewport, which is what puts the home button at the far left and the actions/profile/changelog cluster at the far right, in line with the editor beneath.The brand claim becomes quick edits
"100% Open Source (FREE)" is right on a landing page and dead weight over an open image, so the SDK's new
centreslot carries background removal and face blur instead — the two features that are one click from useful with no configuration, and otherwise several scrolls down the side panel.Deliberately a shortcut layer, not a second home: both still live in the panel with their full controls (background fill colour, per-face toggles). Hidden below
lg, where the panel is the whole screen and half a toolbar is worse than none. Errors stay the panel's job — it has the room to explain and offer a retry.Verification
npm cifrom an emptynode_modulesand a clean build, re-run after the rebase. Checked by driving the built app in headless Chromium: switcher and full identity on the landing view; home glyph far left, shortcuts centred, merged pill far right once an image is loaded.One commit here is a lockfile correction — the first pass paired 0.79.0 with 0.78.0's integrity hash, which
npm cidoes not reject (it matches the hash against its cache and installs the old tarball into the new slot), so only the build caught it.Requires
@unisim/sdk0.79.0, published from universal-platform#113.Generated by Claude Code