Editor toolbar: home glyph only, edit shortcuts, full-bleed bar (SDK 0.79.0) - #43
Closed
JamesmarkeyUK wants to merge 4 commits into
Closed
Editor toolbar: home glyph only, edit shortcuts, full-bleed bar (SDK 0.79.0)#43JamesmarkeyUK wants to merge 4 commits into
JamesmarkeyUK wants to merge 4 commits into
Conversation
With an image open the navbar identity keeps its logo and product name but loses the product dropdown, gaining a house glyph where the chevron was — the SDK's new `onHome` prop. Universal PDF set the precedent: with a document open it drops the whole navbar and pins a home button into its editor toolbar. Images keeps its navbar, so it needed the prop rather than the same trick. The landing view is unchanged and still opens the switcher. Wired to `clearAll` rather than following productHomeHref: navigating would reload the page and drop the open images anyway, and this brings the landing page straight back. REQUIRES @unisim/sdk 0.78.0 on npm. package.json asks for ^0.78.0 while package-lock.json still pins 0.77.1, so `npm ci` (build-windows.yml) will refuse until someone runs `npm install` after the SDK publishes. Do not merge before then. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015TVwu9Zr3bL9vQDfAcEroy
The home-button commit left the other half of the bar as it was: an Actions button on the left and an avatar on the right, which is the split the merged pill exists to remove. AppMenu is now rows only — no trigger, no panel — passed to `actions`, so the editor bar reads home button on the left, one dropdown on the right, matching Universal Converter. All three rows keep their behaviour: the hidden file input still drives "Open/Add images", Metadata keeps its two-line label and its ⚠ badge when the photo carries identifying data, and Clear all keeps its confirm and its count. Rows are inline-styled to the SDK dropdown's rhythm rather than Tailwind — they render inside SDK chrome now — and keep their per-row hover tints (green add, amber metadata, red destructive). Still gated on `hasImages`, so the landing view is untouched: plain avatar, suite switcher, no Actions. Lockfile bumped surgically (version, resolved, integrity, root range) — a full `npm install` here also strips `libc` off rollup's optional platform packages, an artifact of this machine's older npm. `npm ci` verified clean from an empty node_modules, and the app builds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015TVwu9Zr3bL9vQDfAcEroy
…0.79.0) Three changes to what the bar does with an image open, all still gated on `hasImages` so the landing view is untouched. The product name is gone. SDK 0.79.0's `onHome` now replaces the whole identity with a single home glyph rather than keeping the logo and name and swapping the chevron — Universal PDF's open-document toolbar has no branding either. Mid-edit you know which product you are in. The bar goes full-bleed. The editor is full-bleed — thumbnail sidebar hard against the left edge, resize panel against the right — so a centred max-w-7xl navbar floated inset above it. New EDITOR_CONTAINER spans the viewport, which is what puts the home button at the far left and the actions/profile/changelog cluster at the far right, in line with the editor beneath. The brand claim becomes quick edits. "100% Open Source (FREE)" is right on a landing page and dead weight over an open image, so the SDK's new `centre` slot carries background removal and face blur instead — the two features that are one click from useful with no configuration and otherwise several scrolls down the side panel. Deliberately a shortcut layer, not a second home: every one of them still lives in the panel with its full controls. Hidden below lg, where the panel is the whole screen and half a toolbar is worse than none. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015TVwu9Zr3bL9vQDfAcEroy
The previous commit's lock paired version 0.79.0 with 0.78.0's integrity hash. `npm ci` did not fail on that — it matched the hash against its cache and quietly installed the 0.78.0 tarball into the 0.79.0 slot, so the build then type-errored on `centre` not existing. Verified properly this time: `npm ci` from an empty node_modules installs 0.79.0, and the app builds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015TVwu9Zr3bL9vQDfAcEroy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #44 — same two commits, rebased onto
main. This branch was cut from the pre-squash history of #42, so it conflicted.