recipes(pycvc-gl): ship the package layout, republish +cvc.6 - #157
Merged
Conversation
#155 turned pycvc_gl from a flat module into a package (SWIG proxy -> __init__.py, _pycvc_gl*.so moved inside pycvc_gl/, and camera/vehicle/lab/ scenes ship as submodules). The recipe still packaged the old flat globs (_pycvc_gl* / pycvc_gl.py at the site-packages top level), which now match nothing — the packed bundle would be empty. Ship the whole pycvc_gl/ package dir instead, and bump the CPU recipe floor 5 -> 6 (the published +cvc.5 is the old flat module; this republish carries the package layout). compute-revisions still mints the actual revision as max(floor, published+1). Same fix on the pycvc-gl-cuda peer (shared slot).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #155 (which turned
pycvc_glfrom a flat module into a package:SWIG proxy ->
__init__.py,_pycvc_gl*.somoved insidepycvc_gl/, andcamera/vehicle/lab/scenesshipped as submodules).The
pycvc-glrecipe still packaged the old flat globs(
_pycvc_gl*/pycvc_gl.pyat the site-packages top level), which after #155match nothing — the packed bundle would be empty. This ships the whole
pycvc_gl/package dir instead, and bumps the CPU recipe floor 5 -> 6 (thepublished
+cvc.5is the old flat module; this republish carries the packagelayout).
compute-revisionsinpublish-cvcpkg.ymlstill mints the actualrevision as
max(floor, published+1). Same fix on thepycvc-gl-cudapeer(shared
pycvc-glslot).Why now
CVC-Lab/GRL-SNAM's
grl_snam_labre-exports its scene helpers frompycvc_gl(camera/vehicle/lab/scenes, moved in #155), so GRL-SNAM CI must install a
pycvc-glthat actually carries those submodules. This republish (+cvc.6) isone link of the ordered chain that makes CVC-Lab/GRL-SNAM#13 green.
Publish
Republished on the next
v*tag /publish-cvcpkgdispatch (unchanged source;install-layout + revision only).