grl_snam_lab: re-export scene helpers from pycvc_gl (moved there) - #13
Merged
Conversation
camera/vehicle/lab/scenes moved into the pycvc_gl package (generic cvcGL scene utilities). grl_snam_lab keeps its import paths working by re-exporting from pycvc_gl, so nothing downstream breaks.
…lab re-export
grl_snam_lab now re-exports its scene helpers from pycvc_gl (moved there in
libcvc #155), so `from pycvc_gl... import *` must resolve in CI. pip can't
install pycvc-gl (a cvcpkg package), so the pip-based CI failed with
ModuleNotFoundError. Migrate CI off pip:
* .github/workflows/ci.yml — install grl-snam's whole dependency closure
(pycvc-gl, numpy, torch + pytest/ruff/black) from the cvcpkg catalog via
the reusable install-deps action, then run black/ruff/pytest against this
checkout with the prefix's python3.11. Single interpreter (3.11) — the
closure is cp311.
* cvcpkg/recipes/grl-snam — add pytest/ruff/black to depends.build (cvcpkg
has no test-deps group; they stage into the build prefix, stripped on ship)
and a test.sh bundle self-test (`pytest -q`), the cvcpkg-native
counterpart to the CI job.
* grl_snam_lab/lab.py — the compat shim missed _flatten_points (`import *`
skips underscore names); tests/test_lab.py imports it, so re-export it
explicitly or the suite fails to import even with pycvc_gl installed.
Requires the upstream publishes to land first: pytest/ruff/black + torch-cp311
(libcvc-deps) and pycvc-gl +cvc.6 (libcvc #155).
This was referenced Jul 26, 2026
Contributor
Author
|
Pushed CI goes green once the upstream chain lands + publishes:
Verified locally: black/ruff pass on |
…ndings pytest collected test_lab.py which imports pycvc_gl, whose _pycvc_gl extension links libcvc.so.3 / cvcGL / VTK from the prefix's lib/. We run the prefix python directly (no activate), so those weren't on the loader path and import failed with 'libcvc.so.3: cannot open shared object file'. Export $PREFIX/lib on LD_LIBRARY_PATH. Verified locally against the full published closure: black + ruff pass and pytest is 8 passed (incl. the real Lab scene test, headless).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The camera/vehicle/lab/scenes helpers moved into the
pycvc_glpackage (generic cvcGL scene utilities).grl_snam_labkeeps its import paths working by re-exporting frompycvc_gl. Pairs with the libcvc pycvc_gl-package PR and the volrover example update.