feat: forward worker heartbeat options and report temporal-php SDK identity - #790
Merged
Conversation
Collaborator
|
Hey @xepozz 👋🏻 |
rustatian
added
the
C-enhancement
Collaborator
Author
|
would you like me to merge all dependabot suggestions as well? |
Collaborator
|
Yeah, you can merge them into your PR as well. |
rustatian
reviewed
Jul 29, 2026
rustatian
reviewed
Jul 29, 2026
rustatian
reviewed
Jul 29, 2026
rustatian
reviewed
Jul 29, 2026
Add worker_heartbeat_interval to the temporal config, wired into client.Options.WorkerHeartbeatInterval. Out-of-range values are clamped to the sdk-go range (1s-60s) with a warning instead of panicking in Dial. Includes schema entry and an end-to-end test that a configured worker heartbeats to the server. Signed-off-by: Dmitriy Derepko <xepozz@list.ru>
Signed-off-by: Dmitriy Derepko <xepozz@list.ru>
…37.3 Signed-off-by: Dmitriy Derepko <xepozz@list.ru>
xepozz
force-pushed
the
feature/issue-720-worker-heartbeat
branch
from
July 31, 2026 13:59
b0ab7fa to
6f38519
Compare
rustatian
self-requested a review
August 6, 2026 17:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for This PR
Follow-up to temporalio/sdk-php#720. Worker heartbeating is emitted by the
embedded Go SDK inside this plugin, so both the config pass-through and the
SDK-identity fix belong here rather than in sdk-php.
Description of Changes
Two related changes to worker heartbeating:
temporalconfig keysworker_heartbeat_interval(duration,1s–60s; omit for the sdk-go 60sdefault) and
disable_worker_heartbeat(bool), wired intoclient.Options.WorkerHeartbeatInterval. Out-of-range values are rejected inInitDefaultwith a clear error instead of panicking insidetclient.Dial.SdkName/SdkVersion(temporal-go) into the heartbeat body; the existingrewriteNameAndVersioninterceptor only rewrote the gRPC headers. It now alsorewrites the heartbeat body for both RPCs that carry one —
RecordWorkerHeartbeatandShutdownWorker— so PHP workers report astemporal-php-2+ the PHP-SDK version. Confirmed on a live server viatemporal worker describe.No sdk-go or sdk-php changes required. Schema entries and unit tests included.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
git commit -s).CHANGELOG.md. — N/A: noCHANGELOG.mdin this repo.