feat: report PHP SDK identity in worker heartbeats via sdk-go SdkName option - #791
feat: report PHP SDK identity in worker heartbeats via sdk-go SdkName option#791xepozz wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5c214d643
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case heartbeatInterval > 0 && heartbeatInterval < time.Second: | ||
| p.log.Warn("worker_heartbeat_interval below 1s, using 1s", zap.Duration("configured", heartbeatInterval)) | ||
| heartbeatInterval = time.Second |
There was a problem hiding this comment.
When worker_heartbeat_interval is negative (for example, a mistyped -1s), the first clamp condition skips it and passes the value directly to sdk-go, where a negative interval disables worker heartbeats. This contradicts the new schema promise that values below 1s are clamped with a warning and can silently remove worker observability; either clamp all negative values too or explicitly document and validate the negative disable sentinel.
Useful? React with 👍 / 👎.
d5c214d to
3aadd2b
Compare
Set ClientOptions.SdkName/SdkVersion (new in go-sdk) so worker heartbeats report temporal-php. Requires a go.temporal.io/sdk release that adds the option. Signed-off-by: Dmitriy Derepko <xepozz@list.ru>
3aadd2b to
4b8555d
Compare
xepozz
changed the title
1 participant
Report the PHP SDK in worker heartbeats by setting the new
ClientOptions.SdkName/SdkVersion(added in go-sdk), instead of rewriting the heartbeat body in a gRPC interceptor.Depends on a
go.temporal.io/sdkrelease that exposes those options:temporalio/sdk-go@main...xepozz:temporal-sdk-go:feature/worker-heartbeat-sdk-name-override
Until that lands,
go.modis intentionally not bumped, so CI stays red.Wait temporalio/sdk-go#2511 to be merged