Skip to content

fix: satisfy ESLint ReDoS rule in DuckDB view parser #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huyplb merged 1 commit into from
Jul 15, 2026
Merged

fix: satisfy ESLint ReDoS rule in DuckDB view parser #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/core/src/providers/duckDb/duckdb.provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,11 @@ export class DuckDbProvider implements SchemaProvider {
// 5. Views. duckdb_views().sql is the FULL "CREATE VIEW name AS <body>;" —
// strip the header (and trailing ;) so `definition` is just the SELECT body,
// matching what the other providers store and what the generator expects.
// eslint-disable-next-line security/detect-unsafe-regex -- anchored at ^; bounded identifier alternatives (no lazy [\s\S]*)
const VIEW_CREATE_RE = /^\s*CREATE\s+(?:OR\s+REPLACE\s+)?(?:TEMP(?:ORARY)?\s+)?VIEW\s+(?:(?:"[^"]*"|\w+)\s*\.\s*)?(?:"[^"]*"|\w+)\s+AS\s+/i;
for (const vw of rawViews) {
const body = (vw.sql ?? '')
.replace(/^\s*CREATE\s+(?:OR\s+REPLACE\s+)?(?:TEMP(?:ORARY)?\s+)?VIEW\s+[\s\S]*?\s+AS\s+/i, '')
.replace(VIEW_CREATE_RE, '')
.replace(/;\s*$/, '')
.trim();
(views[vw.view_name] ??= []).push({
Expand Down
Loading