fix: satisfy ESLint ReDoS rule in DuckDB view parser#73
Merged
Conversation
Replace the lazy [\s\S]*? view-name matcher with bounded identifier alternatives, matching the pattern used by DB2/SQL Server providers. Co-authored-by: Cursor <cursoragent@cursor.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_37eb2509-55c5-4040-93af-dec3c03c4927) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[\s\S]*?in the DuckDBCREATE VIEWheader stripper with bounded identifier tokens (same approach as DB2 / SQL Server)The 7
detect-non-literal-fs-filenamefindings are warnings only (CLI/config paths by design) — no change needed.Test plan
npx eslint packages/core/src/providers/duckDb/duckdb.provider.tspassesMade with Cursor