Skip to content

Fix SwiftLint findings in client tests #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coenttb merged 3 commits into from
Aug 2, 2026
Merged

Fix SwiftLint findings in client tests #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2dfb55
Fix SwiftLint findings in client tests
coenttb Aug 2, 2026
3f20d34
Fix SwiftLint findings in client tests
coenttb Aug 2, 2026
f6702a7
Fix redundant self in content tests
coenttb Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions Tests/GitHub Core Tests/GitHub.Organization.Repositories.Client Tests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ extension GitHub.Organization.Repositories {
) {
try await client.all(
request,
limit: self.bounds(pages: 2, items: 3),
limit: bounds(pages: 2, items: 3),
duplicate: .reject,
order: .server
)
Expand All @@ -57,8 +57,8 @@ extension GitHub.Organization.Repositories {
throws: GitHub.Organization.Repositories.Traversal.Error<Fixture.Failure>.pages
) {
try await client.all(
self.request(page: .first),
limit: self.bounds(pages: 1, items: 3),
request(page: .first),
limit: bounds(pages: 1, items: 3),
duplicate: .preserve,
order: .server
)
Expand All @@ -70,8 +70,8 @@ extension GitHub.Organization.Repositories {
let client = try self.client()
let task = Task {
try await client.all(
self.request(page: .first),
limit: self.bounds(pages: 2, items: 3),
request(page: .first),
limit: bounds(pages: 2, items: 3),
duplicate: .preserve,
order: .server
)
Expand All @@ -98,22 +98,24 @@ extension GitHub.Organization.Repositories {
return Client.Page(
response: .init(
repositories: [
self.repository(id: 2, name: "beta"),
self.repository(id: 1, name: "alpha"),
repository(id: 2, name: "beta"),
repository(id: 1, name: "alpha"),
]
),
next: self.request(page: second)
)

case 2:
return Client.Page(
response: .init(
repositories: [
self.repository(id: 1, name: "alpha-later"),
self.repository(id: 3, name: "gamma"),
repository(id: 1, name: "alpha-later"),
repository(id: 3, name: "gamma"),
]
),
next: nil
)

default:
throw .unexpected
}
Expand Down
2 changes: 1 addition & 1 deletion Tests/GitHub Core Tests/GitHub.Repository.Content.Client Tests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ extension GitHub.Repository.Content {
}

await #expect(throws: Fixture.Failure.unexpected) {
try await client.get(self.request("swift-package"))
try await client.get(request("swift-package"))
}
}

Expand Down
10 changes: 6 additions & 4 deletions Tests/GitHub Core Tests/GitHub.Repository.Stargazers.Client Tests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ extension GitHub.Repository.Stargazers {
size: .maximum
)
)

case 2:
return .init(response: .init(stargazers: []), next: nil)

default:
throw .unexpected
}
Expand Down Expand Up @@ -75,7 +77,7 @@ extension GitHub.Repository.Stargazers {
) {
try await failing.all(
request,
limit: try self.limit(pages: 1, items: 1)
limit: try limit(pages: 1, items: 1)
)
}

Expand All @@ -92,7 +94,7 @@ extension GitHub.Repository.Stargazers {
) {
try await cycling.all(
request,
limit: try self.limit(pages: 2, items: 1)
limit: try limit(pages: 2, items: 1)
)
}
await #expect(
Expand All @@ -103,14 +105,14 @@ extension GitHub.Repository.Stargazers {
) {
try await cycling.all(
request,
limit: try self.limit(pages: 1, items: 1)
limit: try limit(pages: 1, items: 1)
)
}

let task = Task {
try await cycling.all(
request,
limit: try self.limit(pages: 2, items: 1)
limit: try limit(pages: 2, items: 1)
)
}
task.cancel()
Expand Down
10 changes: 6 additions & 4 deletions Tests/GitHub Core Tests/GitHub.User.Repositories.Client Tests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ extension GitHub.User.Repositories {
response: .init(repositories: []),
next: .init(page: second, size: .maximum)
)

case 2:
return .init(response: .init(repositories: []), next: nil)

default:
throw .unexpected
}
Expand Down Expand Up @@ -61,7 +63,7 @@ extension GitHub.User.Repositories {
) {
try await failing.all(
request,
limit: try self.limit(pages: 1, items: 1)
limit: try limit(pages: 1, items: 1)
)
}

Expand All @@ -78,7 +80,7 @@ extension GitHub.User.Repositories {
) {
try await cycling.all(
request,
limit: try self.limit(pages: 2, items: 1)
limit: try limit(pages: 2, items: 1)
)
}
await #expect(
Expand All @@ -89,14 +91,14 @@ extension GitHub.User.Repositories {
) {
try await cycling.all(
request,
limit: try self.limit(pages: 1, items: 1)
limit: try limit(pages: 1, items: 1)
)
}

let task = Task {
try await cycling.all(
request,
limit: try self.limit(pages: 2, items: 1)
limit: try limit(pages: 2, items: 1)
)
}
task.cancel()
Expand Down
Loading