Skip to content

Fix SwiftLint findings in client tests - #8

Merged
coenttb merged 3 commits into
mainfrom
issue-5-swiftlint
Aug 2, 2026
Merged

Fix SwiftLint findings in client tests#8
coenttb merged 3 commits into
mainfrom
issue-5-swiftlint

Conversation

@coenttb

@coenttb coenttb commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Fixes #5.

Removes the ten reported SwiftLint findings in the two affected client test files only. No public API, error-semantic, target/product, or workflow changes.

Local evidence: workspace package lint --package-path . reports no errors in the touched files; existing advisory findings elsewhere are unchanged. The coordinator’s full-tier Actions qualification remains the merge gate.

@coenttb coenttb left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review — CLEAN for commit e2dfb55.

The complete PR diff is confined to the two affected client-test files (10 SwiftLint mechanical corrections: redundant self removal and switch-case spacing). It introduces no API, behavioral, target, product, workflow, or tracking-surface change. The branch is one commit ahead of base 50d3bc7.

Required full-tier workflow_dispatch evidence is still pending; landing remains gated on an exact-head green run and final state guards.

@coenttb coenttb left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent re-review — BLOCKED for commit 3f20d34.

I read the complete replacement diff against base 50d3bc7. It is limited to three client-test files and consists of mechanically neutral SwiftLint corrections: redundant self removal and switch-case spacing, with the existing Stargazers corrections retained. No production, API, target, workflow, or tracking change is present.

The exact-head CI run https://github.com/swift-foundations/swift-github/actions/runs/30742028060 has a required SwiftLint failure: https://github.com/swift-foundations/swift-github/actions/runs/30742028060/job/91481039312. Its first actionable annotation is redundant_self at Tests/GitHub Core Tests/GitHub.Repository.Content.Client Tests.swift:28, a file outside this PR diff. Therefore the required gate is not satisfied and no full-tier dispatch or merge is authorized.

Next owner: a maintainer with source-edit authority for the Content client test. After a correction is pushed, obtain a new exact-head full-tier workflow_dispatch green result before requesting another landing review. PR #8 and Bug #5 remain open.

@coenttb coenttb left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent re-review — CLEAN for commit f6702a7.

I read the complete replacement diff against base 50d3bc7. It is confined to four test files and consists of SwiftLint mechanical corrections: redundant self removal and switch-case whitespace. No production, API, error-semantic, target, product, workflow, or tracking change is present.

The strict SwiftLint, Workspace lint, and fresh capped test evidence supplied for this exact head are task-attributed. I independently checked the complete diff and live PR state. The one full-tier workflow_dispatch qualification remains required before landing.

Landing observation: main has no configured branch-protection status-check requirement. Final merge remains contingent on the exact-head full-tier run and immediate state guards.

@coenttb
coenttb merged commit 7ce3cbd into main Aug 2, 2026
44 of 46 checks passed
@coenttb
coenttb deleted the issue-5-swiftlint branch August 2, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Canonical main is red: gating swift-format/SwiftLint legs fail

1 participant