Skip to content

fix: resolve lint:packages warnings blocking CI (--max-warnings 0) #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davedbase merged 2 commits into from
Aug 16, 2026
+3 −2
Merged

fix: resolve lint:packages warnings blocking CI (--max-warnings 0) #1012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
470c9c2
fix: resolve lint:packages warnings blocking CI (--max-warnings 0)
davedbase Aug 16, 2026
976fe62
Merge branch 'main' into patch/lint-max-warnings-fixes
davedbase Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/memo/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ export function createRcMemo<T>(
return {
memo: createMemo(
prev => {
let result = calc(prev);
const result = calc(prev);
lastSeenValue = result;
return result;
},
Expand All @@ -519,7 +519,7 @@ export function createRcMemo<T>(
} else {
existing.refCount++;
}
let existing2 = existing!;
const existing2 = existing!;
onCleanup(() => {
existing2.refCount--;
if (existing2.refCount === 0) {
Expand Down
1 change: 1 addition & 0 deletions packages/websocket/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ export const makeReconnectingWS = (
};
let events: Parameters<WebSocket["addEventListener"]>[] = [["close", onClose]];
const getWS = () => {
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- ws is undefined on the first call, TS just doesn't reflect that in its declared type
ws?.removeEventListener("close", onClose);
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
if (ws && ws.readyState < 2) ws.close();
Expand Down
Loading