fix: resolve lint:packages warnings blocking CI (--max-warnings 0) - #1012
Conversation
- memo: two `let` bindings that are never reassigned (prefer-const) - websocket: ws?.removeEventListener flagged as an unnecessary optional chain by @typescript-eslint/no-unnecessary-condition — this is a false positive, ws is genuinely undefined on the first getWS() call (declared without an initializer), TS's declared type just doesn't reflect that. Suppressed with the same eslint-disable pattern already used one line below for the identical false positive, rather than removing the `?.` (which would throw on first connect). No behavior change; verified via full memo/websocket test suites.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan includes up to 4 reviews per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe changes replace two mutable memo bindings with immutable bindings and add an ESLint suppression comment for the initial undefined WebSocket reference. Runtime behavior remains unchanged. ChangesMemo declaration cleanup
WebSocket lint clarification
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized lint-only change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
letbindings that are never reassigned (prefer-const)?.(which would throw on first connect).No behavior change; verified via full memo/websocket test suites.
Summary by CodeRabbit