Add e2e-test-kubevirt-aws presubmit for oadp-dev 5.0 - #83078
Conversation
WalkthroughThe OADP 5.0 and 5.1 CI configurations add optional, change-triggered AWS jobs for KubeVirt-enabled end-to-end tests. ChangesOADP KubeVirt AWS end-to-end testing
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
oadp-1.5 and oadp-1.6 already run make TEST_VIRT=true test-e2e as a gating presubmit (e2e-test-kubevirt-aws); oadp-dev only had it as a daily periodic, with no way to get presubmit signal on a PR before merge. Adds the same job to the oadp-dev 5.0/5.1 variants, but as optional (manually triggered via /test, doesn't block merge) rather than gating like 1.5/1.6 -- oadp-dev is the active development branch and this KubeVirt path is newer/less proven there. This is needed for openshift/oadp-operator#2350 (kubevirt-datamover VM backup/restore e2e coverage) to actually be runnable against a PR before merge -- without this, those new specs only get exercised by the existing daily periodic, well after the PR that added them has merged. Related: openshift#83049 (kdm-controller/kdm-plugin presubmit e2e using this same TEST_VIRT=true path). Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
725b2e2 to
e6eab8c
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse pull-ci-openshift-oadp-operator-oadp-dev-5.0-e2e-test-kubevirt-aws pull-ci-openshift-oadp-operator-oadp-dev-5.1-e2e-test-kubevirt-aws Note Responses generated with Claude |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Matches oadp-1.5/oadp-1.6, where this same job is already gating rather than optional. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
|
/pj-rehearse pull-ci-openshift-oadp-operator-oadp-dev-5.0-e2e-test-kubevirt-aws pull-ci-openshift-oadp-operator-oadp-dev-5.1-e2e-test-kubevirt-aws Note Responses generated with Claude |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
removing 5.1 |
Scope this to just the 5.0 variant for now. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-oadp-operator-oadp-dev-5.0-e2e-test-kubevirt-aws Note Responses generated with Claude |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, shubham-pampattiwar, sseago, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack Note Responses generated with Claude |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@kaovilai: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Adds
e2e-test-kubevirt-aws(make TEST_VIRT=true test-e2e) as a gating presubmit foroadp-dev(5.0 only) — matchingoadp-1.5andoadp-1.6, where this same job is already gating (auto-triggers on relevant file changes and must pass to merge).oadp-devonly had this as a daily periodic (e2e-test-kubevirt-aws-periodic,0 4 * * *), with no way to get presubmit signal on a PR before it merges.Why
Needed for openshift/oadp-operator#2350 (kubevirt-datamover VM backup/restore e2e coverage — multi-PVC, incremental backup sequence, restore from a full CBT backup) to actually be gated by CI. Without this, those specs only get exercised by the existing daily periodic, well after any regression-introducing PR has already merged.
Related
migtools/kubevirt-datamover-controller/kubevirt-datamover-pluginusing this sameTEST_VIRT=truepath. Independent change, same underlying mechanism.Test plan
make update/ ci-operator's own config+registry validation passes./pj-rehearsetriggered against real cluster provisioning + OLM install + KubeVirt/HCO install.Note
Responses generated with Claude