Skip to content

Add e2e-test-kubevirt-aws presubmit for oadp-dev 5.0 - #83078

Merged
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
kaovilai:oadp-dev-kubevirt-presubmit-optional
Aug 7, 2026
Merged

Add e2e-test-kubevirt-aws presubmit for oadp-dev 5.0#83078
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
kaovilai:oadp-dev-kubevirt-presubmit-optional

Conversation

@kaovilai

@kaovilai kaovilai commented Aug 7, 2026

Copy link
Copy Markdown
Member

Summary

Adds e2e-test-kubevirt-aws (make TEST_VIRT=true test-e2e) as a gating presubmit for oadp-dev (5.0 only) — matching oadp-1.5 and oadp-1.6, where this same job is already gating (auto-triggers on relevant file changes and must pass to merge).

oadp-dev only had this as a daily periodic (e2e-test-kubevirt-aws-periodic, 0 4 * * *), with no way to get presubmit signal on a PR before it merges.

Why

Needed for openshift/oadp-operator#2350 (kubevirt-datamover VM backup/restore e2e coverage — multi-PVC, incremental backup sequence, restore from a full CBT backup) to actually be gated by CI. Without this, those specs only get exercised by the existing daily periodic, well after any regression-introducing PR has already merged.

Related

Test plan

  • make update / ci-operator's own config+registry validation passes.
  • /pj-rehearse triggered against real cluster provisioning + OLM install + KubeVirt/HCO install.

Note

Responses generated with Claude

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The OADP 5.0 and 5.1 CI configurations add optional, change-triggered AWS jobs for KubeVirt-enabled end-to-end tests.

Changes

OADP KubeVirt AWS end-to-end testing

Layer / File(s) Summary
Add KubeVirt AWS test jobs
ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-dev__5.0.yaml, ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-dev__5.1.yaml
Adds optional e2e-test-kubevirt-aws jobs that use the AWS cluster profile and run make TEST_VIRT=true test-e2e when relevant files change.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: shubham-pampattiwar, joeavaikath

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only CI YAML and adds no Ginkgo It, Describe, Context, or When titles; the job name is a static CI identifier.
Test Structure And Quality ✅ Passed The pull request changes only YAML configuration and generated presubmit files; it adds no Ginkgo test code, so the listed test-quality checks are not applicable.
Microshift Test Compatibility ✅ Passed The PR changes only CI YAML and generated Prow job metadata; it adds no new Ginkgo tests or test declarations requiring MicroShift compatibility review.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The HEAD diff changes only three CI YAML files; it adds no Go/test files or Ginkgo declarations, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only ci-operator job/config YAML; it adds no deployment manifests, operator code, controllers, or topology-related scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only YAML CI configuration and generated Prow metadata; it adds no OTE binary source or process-level stdout/logging code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only ci-operator YAML and generated presubmit metadata; it adds no Ginkgo declarations or test/networking code, so this check is not applicable.
No-Weak-Crypto ✅ Passed The pull request only removes optional: true from two YAML jobs and two generated presubmit entries; it adds no cryptography, weak algorithms, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The added 5.0/5.1 CI and generated Prow YAML contain no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root execution settings.
No-Sensitive-Data-In-Logs ✅ Passed The feature diff adds only standard secret references and read-only mounts; it adds no secret values, logging commands, or output templates that expose sensitive data.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the added e2e-test-kubevirt-aws presubmit and accurately names the 5.0 variant, although it omits 5.1.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2026
oadp-1.5 and oadp-1.6 already run make TEST_VIRT=true test-e2e as a
gating presubmit (e2e-test-kubevirt-aws); oadp-dev only had it as a
daily periodic, with no way to get presubmit signal on a PR before merge.

Adds the same job to the oadp-dev 5.0/5.1 variants, but as optional
(manually triggered via /test, doesn't block merge) rather than gating
like 1.5/1.6 -- oadp-dev is the active development branch and this
KubeVirt path is newer/less proven there.

This is needed for openshift/oadp-operator#2350 (kubevirt-datamover VM
backup/restore e2e coverage) to actually be runnable against a PR before
merge -- without this, those new specs only get exercised by the
existing daily periodic, well after the PR that added them has merged.

Related: openshift#83049 (kdm-controller/kdm-plugin presubmit
e2e using this same TEST_VIRT=true path).

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai
kaovilai force-pushed the oadp-dev-kubevirt-presubmit-optional branch from 725b2e2 to e6eab8c Compare August 7, 2026 15:41
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@kaovilai

kaovilai commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-oadp-operator-oadp-dev-5.0-e2e-test-kubevirt-aws pull-ci-openshift-oadp-operator-oadp-dev-5.1-e2e-test-kubevirt-aws

Note

Responses generated with Claude

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Matches oadp-1.5/oadp-1.6, where this same job is already gating rather
than optional.

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai kaovilai changed the title Add optional e2e-test-kubevirt-aws presubmit for oadp-dev Add e2e-test-kubevirt-aws presubmit for oadp-dev Aug 7, 2026
@kaovilai

kaovilai commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-oadp-operator-oadp-dev-5.0-e2e-test-kubevirt-aws pull-ci-openshift-oadp-operator-oadp-dev-5.1-e2e-test-kubevirt-aws

Note

Responses generated with Claude

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2026
@kaovilai

kaovilai commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

removing 5.1

Scope this to just the 5.0 variant for now.

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai kaovilai changed the title Add e2e-test-kubevirt-aws presubmit for oadp-dev Add e2e-test-kubevirt-aws presubmit for oadp-dev 5.0 Aug 7, 2026
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2026

@weshayutin weshayutin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@kaovilai: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-oadp-operator-oadp-dev-5.0-e2e-test-kubevirt-aws openshift/oadp-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@kaovilai

kaovilai commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-oadp-operator-oadp-dev-5.0-e2e-test-kubevirt-aws

Note

Responses generated with Claude

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaovilai

kaovilai commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse rehearsed clean against real cluster provisioning + OLM install + KubeVirt/HCO install (ci/rehearse/openshift/oadp-operator/oadp-dev/5.0-e2e-test-kubevirt-aws succeeded).

/pj-rehearse ack

Note

Responses generated with Claude

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 7, 2026
@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@kaovilai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/oadp-operator/oadp-dev/5.1-e2e-test-kubevirt-aws 188c354 link unknown /pj-rehearse pull-ci-openshift-oadp-operator-oadp-dev-5.1-e2e-test-kubevirt-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 4adb86b into openshift:main Aug 7, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants