AUTOSCALE-543: Add lint and e2e tests for kedacore-http-add-on - #82805
AUTOSCALE-543: Add lint and e2e tests for kedacore-http-add-on#82805linkvt wants to merge 2 commits into
Conversation
|
@linkvt: This pull request references AUTOSCALE-543 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe OpenShift CI configuration changes the build root, adds the gRPC echo image to build outputs, and defines conditional lint and AWS end-to-end workflows. ChangesCI workflow configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant CIWorkflow
participant SourceContainer
participant BuildOutputs
participant AWSCluster
CIWorkflow->>SourceContainer: Run AWS end-to-end setup from src
SourceContainer->>BuildOutputs: Consume operator, interceptor, and scaler images
SourceContainer->>AWSCluster: Configure AWS cluster
CIWorkflow->>SourceContainer: Run AWS end-to-end command from src
SourceContainer->>BuildOutputs: Consume gRPC echo image
SourceContainer->>AWSCluster: Execute end-to-end tests
CIWorkflow->>AWSCluster: Run cleanup and report results
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: linkvt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ci-operator/config/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main.yaml (1)
6-9: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin the
golangci-lintbase image.
tag: latestallows the lint toolchain to change without a configuration change. The supplied mirror entries are versioned, and the supplied context does not showci/golangci-lint:latest. Use an existing versioned tag, or verify that thelatestImageStreamTag is intentionally maintained.ci-operatorimports base images as ImageStreamTags, so a missing tag prevents the lint job from starting. (docs.ci.openshift.org)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main.yaml` around lines 6 - 9, Update the golangci-lint image configuration to use an existing versioned ImageStreamTag instead of tag: latest, matching the available mirror entries and preserving the ci/golangci-lint image reference so ci-operator can start the lint job.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main.yaml`:
- Around line 94-101: Move the e2e-clean step from steps.test to steps.post so
it runs after failures and before AWS cluster teardown. When overriding the
workflow post list, retain both ipi-aws-post and send-results-to-reportportal,
alongside e2e-clean.
---
Nitpick comments:
In
`@ci-operator/config/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main.yaml`:
- Around line 6-9: Update the golangci-lint image configuration to use an
existing versioned ImageStreamTag instead of tag: latest, matching the available
mirror entries and preserving the ci/golangci-lint image reference so
ci-operator can start the lint job.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: c48cd26e-c737-44d3-b4e8-cb28d6a2049c
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main.yaml
17dfd73 to
db6a808
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main.yaml`:
- Around line 64-71: Update the custom steps.post list in the OpenShift KEDA
HTTP add-on configuration to retain e2e-clean and append both ipi-aws-post and
send-results-to-reportportal in that order, preserving AWS cluster
gathering/deprovisioning and result reporting.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: e3bdb0bf-42fc-447f-b696-fb58e31d4482
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main.yaml
|
/pj-rehearse |
|
@linkvt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
db6a808 to
8a9f5a0
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse pull-ci-openshift-kedacore-http-add-on-main-http-addon-e2e-aws |
|
@linkvt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@linkvt: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
/pj-rehearse pull-ci-openshift-kedacore-http-add-on-main-lint |
|
@linkvt: your |
|
/pj-rehearse pull-ci-openshift-kedacore-http-add-on-main-lint |
|
@linkvt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Add CI test configuration for the HTTP add-on: a lint presubmit using the golangci-lint CI image, and an e2e test on AWS that installs KEDA via Helm, deploys the http-add-on from CI-built images, and runs the default profile tests. Changes: - Add grpc-echo test image build - Add golangci-lint base image and lint presubmit test - Add http-addon-e2e-aws inline multi-stage test (setup/run/clean) Signed-off-by: Vincent Link <vlink@redhat.com>
8a9f5a0 to
fb7da88
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse pull-ci-openshift-kedacore-http-add-on-main-http-addon-e2e-aws pull-ci-openshift-kedacore-http-add-on-main-lint |
|
@linkvt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
ci-operator/config/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main.yaml (1)
67-74:⚠️ Potential issue | 🟠 MajorPreserve the
ipi-awspost steps.The local
steps.postlist contains onlye2e-clean. Appendipi-aws-postandsend-results-to-reportportalaftere2e-clean. Theipi-awsworkflow defines these steps for AWS cluster gathering, deprovisioning, and result reporting. The local configuration overrides workflow fields, so omitting them can leave AWS resources and omit test results. (steps.ci.openshift.org)This is the same unresolved issue reported in the previous review comments.
Proposed fix
- as: e2e-clean cli: latest commands: GOFLAGS="" make e2e-test-openshift-clean from: src resources: requests: cpu: 100m + - chain: ipi-aws-post + - ref: send-results-to-reportportalAlso applies to: 100-100
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main.yaml` around lines 67 - 74, Extend the local steps.post list after e2e-clean with the ipi-aws-post and send-results-to-reportportal steps, preserving their workflow-defined configuration so AWS cluster cleanup and result reporting remain enabled.Source: MCP tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In
`@ci-operator/config/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main.yaml`:
- Around line 67-74: Extend the local steps.post list after e2e-clean with the
ipi-aws-post and send-results-to-reportportal steps, preserving their
workflow-defined configuration so AWS cluster cleanup and result reporting
remain enabled.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: c418b281-7af3-4bbc-979b-b74bbffbd7db
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/kedacore-http-add-on/openshift-kedacore-http-add-on-main.yaml
…CACHE Signed-off-by: Vincent Link <vlink@redhat.com>
|
/pj-rehearse pull-ci-openshift-kedacore-http-add-on-main-http-addon-e2e-aws pull-ci-openshift-kedacore-http-add-on-main-lint |
|
@linkvt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@linkvt: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
TODO
.ci-operator.yamlin http addon repo and revert changes hereRequires: openshift/kedacore-http-add-on#6
Add CI test configuration for the HTTP add-on: a lint presubmit using the golangci-lint CI image, and an e2e test on AWS that installs KEDA via Helm, deploys the http-add-on from CI-built images, and runs the default profile tests.
Changes
Summary by CodeRabbit
kedacore-http-add-on.grpc-echotest image.golangci-lintpresubmit test with documentation-only skip conditions.grpc-echoimages to the AWS test.GOLANGCI_LINT_CACHE.kedacore-http-add-onPR#6.