[release-4.21] OCPBUGS-98747: Remove --enable-interconnect flag from OVN-K manifests#3055
Conversation
Upstream OVN-K removed --enable-interconnect in ovn-kubernetes/ovn-kubernetes#6303 making interconnect the only supported topology. The flag is no longer recognized by the binary and causes startup failures. Also removes unused OVN_INTERCONNECT_CONFIGMAP_NAME constant and GetInterConnectConfigMap function from pkg/util/util.go. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit 09b660b)
Older OVN-K binaries still require --enable-interconnect, while newer ones (post ovn-kubernetes/ovn-kubernetes#6303) reject it as an unknown flag. Check --help output at startup to determine whether to pass the flag. Drop this commit once all supported OVN-K images have the flag removed (i.e., no upgrade path from a version that still has it). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Patryk Diak <pdiak@redhat.com> (cherry picked from commit c2241d4)
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-88307 has been cloned as Jira Issue OCPBUGS-98747. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-98747, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (core-networking-bot@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pipeline required |
|
Scheduling required tests: Scheduling tests matching the |
|
/retest |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/testwith openshift/cluster-network-operator/release-4.21/e2e-gcp-ovn openshift/ovn-kubernetes#3300 |
|
@arkadeepsen: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@arkadeepsen: This pull request references Jira Issue OCPBUGS-98747, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (core-networking-bot@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
Scheduling required tests: Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test 4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade |
|
/test e2e-azure-ovn-upgrade |
|
/test 4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade |
|
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw |
|
/tide refresh |
72b5cba
into
openshift:release-4.21
|
@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-98747 Jira Issue OCPBUGS-98747 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is an automated cherry-pick of #3028
/assign arkadeepsen