Skip to content

[release-4.22] OCPBUGS-88307: Remove --enable-interconnect flag from OVN-K manifests#3028

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.22from
arkadeepsen:remove-ic-4.22
Jun 11, 2026
Merged

[release-4.22] OCPBUGS-88307: Remove --enable-interconnect flag from OVN-K manifests#3028
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.22from
arkadeepsen:remove-ic-4.22

Conversation

@arkadeepsen

Copy link
Copy Markdown
Member

Manual cherry-pick of #3008

Resolved conflicts in:

  • bindata/network/ovn-kubernetes/common/008-script-lib.yaml
  • bindata/network/ovn-kubernetes/managed/ovnkube-control-plane.yaml
  • bindata/network/ovn-kubernetes/self-hosted/ovnkube-control-plane.yaml

kyrtapz and others added 2 commits June 11, 2026 09:55
Upstream OVN-K removed --enable-interconnect in
ovn-kubernetes/ovn-kubernetes#6303
making interconnect the only supported topology. The flag
is no longer recognized by the binary and causes startup failures.

Also removes unused OVN_INTERCONNECT_CONFIGMAP_NAME constant and
GetInterConnectConfigMap function from pkg/util/util.go.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Patryk Diak <pdiak@redhat.com>
(cherry picked from commit 09b660b)
Older OVN-K binaries still require --enable-interconnect, while
newer ones (post ovn-kubernetes/ovn-kubernetes#6303) reject it as
an unknown flag. Check --help output at startup to determine
whether to pass the flag.

Drop this commit once all supported OVN-K images have the flag
removed (i.e., no upgrade path from a version that still has it).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Patryk Diak <pdiak@redhat.com>
(cherry picked from commit c2241d4)
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 03f24bb0-b93c-4a65-a6f0-e55242793387

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arkadeepsen

Copy link
Copy Markdown
Member Author

/jira cherrypick OCPBUGS-88306

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@arkadeepsen: Jira Issue OCPBUGS-88306 has been cloned as Jira Issue OCPBUGS-88307. Will retitle bug to link to clone.
/retitle OCPBUGS-88307: [release-4.22] Remove --enable-interconnect flag from OVN-K manifests

Details

In response to this:

/jira cherrypick OCPBUGS-88306

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] Remove --enable-interconnect flag from OVN-K manifests OCPBUGS-88307: [release-4.22] Remove --enable-interconnect flag from OVN-K manifests Jun 11, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 11, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@arkadeepsen: This pull request references Jira Issue OCPBUGS-88307, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry-pick of #3008

Resolved conflicts in:

  • bindata/network/ovn-kubernetes/common/008-script-lib.yaml
  • bindata/network/ovn-kubernetes/managed/ovnkube-control-plane.yaml
  • bindata/network/ovn-kubernetes/self-hosted/ovnkube-control-plane.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@arkadeepsen arkadeepsen changed the title OCPBUGS-88307: [release-4.22] Remove --enable-interconnect flag from OVN-K manifests [release-4.22] OCPBUGS-88307: Remove --enable-interconnect flag from OVN-K manifests Jun 11, 2026
@arkadeepsen

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 11, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@arkadeepsen: This pull request references Jira Issue OCPBUGS-88307, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-88306 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-88306 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@arkadeepsen

Copy link
Copy Markdown
Member Author

/retest-required

@arkadeepsen

Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@arkadeepsen: This pull request references Jira Issue OCPBUGS-88307, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-88306 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-88306 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyrtapz

kyrtapz commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

/testwith openshift/ovn-kubernetes/master/e2e-aws-ovn openshift/ovn-kubernetes#3244

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@kyrtapz, testwith: could not generate prow job. ERROR:

could not determine ci op config from metadata: got unexpected http 404 status code from configresolver: failed to get config: could not find any config for branch master on repo openshift/ovn-kubernetes

@kyrtapz

kyrtapz commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

/testwith openshift/cluster-network-operator/master/e2e-aws-ovn openshift/ovn-kubernetes#3244

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@kyrtapz, testwith: could not generate prow job. ERROR:

BUG: test 'e2e-aws-ovn' not found in injected config

@kyrtapz

kyrtapz commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

/testwith openshift/cluster-network-operator/master/e2e-gcp-ovn openshift/ovn-kubernetes#3244

1 similar comment
@kyrtapz

kyrtapz commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

/testwith openshift/cluster-network-operator/master/e2e-gcp-ovn openshift/ovn-kubernetes#3244

@arkadeepsen

Copy link
Copy Markdown
Member Author

/retest-required

@arkadeepsen

Copy link
Copy Markdown
Member Author

/testwith openshift/cluster-network-operator/release-4.22/e2e-gcp-ovn openshift/ovn-kubernetes#3244

@kyrtapz

kyrtapz commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 11, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2026
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkadeepsen, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2026
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@arkadeepsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-rhcos10-techpreview 8fcea4a link false /test e2e-aws-ovn-rhcos10-techpreview
ci/prow/security 8fcea4a link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@arkadeepsen

Copy link
Copy Markdown
Member Author

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 11, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@arkadeepsen: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit a39ae7a into openshift:release-4.22 Jun 11, 2026
28 of 30 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@arkadeepsen: Jira Issue Verification Checks: Jira Issue OCPBUGS-88307
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-88307 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Manual cherry-pick of #3008

Resolved conflicts in:

  • bindata/network/ovn-kubernetes/common/008-script-lib.yaml
  • bindata/network/ovn-kubernetes/managed/ovnkube-control-plane.yaml
  • bindata/network/ovn-kubernetes/self-hosted/ovnkube-control-plane.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 4.22.0-0.nightly-2026-06-12-105703

@arkadeepsen

Copy link
Copy Markdown
Member Author

/cherrypick release-4.21

@openshift-cherrypick-robot

Copy link
Copy Markdown

@arkadeepsen: new pull request created: #3055

Details

In response to this:

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.