Skip to content

⚡ Bolt: Replace expensive FindObjectsOfType Server lookups with O(1) NetworkMap singleton #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mleem97 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: Replace expensive FindObjectsOfType Server lookups with O(1) NetworkMap singleton #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/Infrastructure/Scripting/Lua/Modules/LuaServerModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,21 @@ namespace gregCore.Infrastructure.Scripting.Lua.Modules;

public static class LuaServerModule
{
// Optimization: Helper to use O(1) game-managed collection with fallback to O(N) FindObjectsOfType
private static System.Collections.Generic.IEnumerable<Il2Cpp.Server> GetServers()
{
var nm = Il2Cpp.NetworkMap.instance;
if (nm != null && nm.servers != null)
{
foreach (var kvp in nm.servers) yield return kvp.Value;
}
else
{
var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
foreach (var s in servers) yield return s;
}
}

public static void Register(Table greg, Script script, string modId)
{
var serverTable = new Table(script);
Expand All @@ -21,10 +36,9 @@ public static void Register(Table greg, Script script, string modId)
{
try
{
var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
var result = new Table(script);
int i = 1;
foreach (var s in servers)
foreach (var s in GetServers())
{
try
{
Expand Down Expand Up @@ -80,8 +94,7 @@ public static void Register(Table greg, Script script, string modId)
{
try
{
var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
foreach (var s in servers)
foreach (var s in GetServers())
{
try
{
Expand All @@ -104,8 +117,7 @@ public static void Register(Table greg, Script script, string modId)
try
{
int repaired = 0;
var servers = UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>();
foreach (var s in servers)
foreach (var s in GetServers())
{
try
{
Expand Down
Loading