Skip to content

⚡ Bolt: Replace expensive FindObjectsOfType Server lookups with O(1) NetworkMap singleton - #211

Open
mleem97 wants to merge 1 commit into
mainfrom
perf/lua-server-module-14736905850215655255
Open

⚡ Bolt: Replace expensive FindObjectsOfType Server lookups with O(1) NetworkMap singleton#211
mleem97 wants to merge 1 commit into
mainfrom
perf/lua-server-module-14736905850215655255

Conversation

@mleem97

@mleem97 mleem97 commented Jul 31, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced expensive O(N) FindObjectsOfType<Il2Cpp.Server>() calls in LuaServerModule.cs with an O(1) collection lookup using Il2Cpp.NetworkMap.instance.servers. Added a robust fallback to FindObjectsOfType during uninitialized game states.
🎯 Why: FindObjectsOfType is extremely slow and performs an expensive scene traversal. LuaServerModule was calling this for operations like get_all, repair, and repair_all, which could become a significant performance bottleneck in large server maps or when scripts execute these frequently.
📊 Impact: Reduces O(N) scene traversals to O(1) dictionary lookups, substantially improving execution times of Lua Server API functions (especially in end-game networks with many objects).
🔬 Measurement: Profile the execution time of greg.server.get_all() via Lua scripts and observe reduced CPU frame spikes compared to the unoptimized method. Verify using the test suite.


PR created automatically by Jules for task 14736905850215655255 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant