Skip to content

Fixing Select.expect implementation to fit with ExpectBase refactor #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rodrigo Brandão (rodrigobr-msft) merged 1 commit into from
Aug 4, 2026
Merged

Fixing Select.expect implementation to fit with ExpectBase refactor #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dev/microsoft-agents-testing/microsoft_agents/testing/core/fluent/select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from pydantic import BaseModel

from .backend import ModelPredicate, DictionaryTransform
from .expect import Expect
from .expect import ExpectBase

ModelT = TypeVar("ModelT", bound=dict | BaseModel)

Expand Down Expand Up @@ -49,9 +49,9 @@ def __init__(
) -> None:
self._items = list(items)

def expect(self) -> Expect:
def expect(self) -> ExpectBase[ModelT]:
"""Get an Expect instance for assertions on the current selection."""
return Expect(self._items)
return ExpectBase[ModelT](self._items)
Comment thread
rodrigobr-msft marked this conversation as resolved.

def _child(self, items: Sequence[ModelT]) -> Self:
"""Create a child Select with new items, inheriting selector and quantifier."""
Expand Down
6 changes: 0 additions & 6 deletions dev/microsoft-agents-testing/tests/core/fluent/test_select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,6 @@ def test_init_with_generator(self):
class TestSelectExpect:
"""Tests for the expect() method."""

def test_expect_returns_expect_instance(self):
"""expect() returns an Expect instance."""
select = Select([{"name": "a"}])
result = select.expect()
assert isinstance(result, Expect)

def test_expect_with_correct_items(self):
"""expect() passes the current items to Expect."""
items = [{"name": "a"}, {"name": "b"}]
Expand Down
Loading