Fixing Select.expect implementation to fit with ExpectBase refactor

[Rodrigo Brandão (rodrigobr-msft)]

No description provided.

[Copilot]

Pull request overview

This PR updates the testing framework’s fluent Select.expect() to align with the newer ExpectBase refactor, ensuring selections can produce the updated assertion object.

Changes:

• Switch SelectBase.expect() to return ExpectBase[ModelT] instead of Expect.
• Remove a test that asserted the old concrete Expect return type (without adding an updated contract assertion).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
dev/microsoft-agents-testing/microsoft_agents/testing/core/fluent/select.py	Updates expect() to use ExpectBase in line with the refactor.
dev/microsoft-agents-testing/tests/core/fluent/test_select.py	Removes the old “returns Expect” assertion test for expect().

Suppressed comments (1)

dev/microsoft-agents-testing/tests/core/fluent/test_select.py:59

• The test suite no longer asserts the contract of Select.expect() returning an Expect/ExpectBase-like assertion object. Instead of deleting the return-type assertion entirely, update it to validate the new ExpectBase-based design (and use the imported Expect so it doesn’t become unused).

    def test_expect_with_correct_items(self):
        """expect() passes the current items to Expect."""
        items = [{"name": "a"}, {"name": "b"}]
        select = Select(items)
        expect = select.expect()
        assert expect._items == items

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.