-
Notifications
You must be signed in to change notification settings - Fork 2k
Solution #2164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Solution #2164
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,25 @@ | ||
| from app.split_integer import split_integer | ||
| from app import split_integer | ||
|
|
||
|
|
||
| def test_sum_of_the_parts_should_be_equal_to_value() -> None: | ||
| pass | ||
| result = split_integer.split_integer(17, 4) | ||
|
|
||
| assert sum(result) == 17 | ||
| assert len(result) == 4 | ||
| assert max(result) - min(result) <= 1 | ||
|
|
||
|
|
||
| def test_should_split_into_equal_parts_when_value_divisible_by_parts() -> None: | ||
| pass | ||
| assert split_integer.split_integer(12, 4) == [3, 3, 3, 3] | ||
|
|
||
|
|
||
| def test_should_return_part_equals_to_value_when_split_into_one_part() -> None: | ||
| pass | ||
| assert split_integer.split_integer(8, 1) == [8] | ||
|
|
||
|
|
||
| def test_parts_should_be_sorted_when_they_are_not_equal() -> None: | ||
| pass | ||
| assert split_integer.split_integer(11, 4) == [2, 3, 3, 3] | ||
|
|
||
|
|
||
| def test_should_add_zeros_when_value_is_less_than_number_of_parts() -> None: | ||
| pass | ||
| assert split_integer.split_integer(3, 5) == [0, 0, 1, 1, 1] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist item #1 violation: This stores the result in a variable before asserting. For simple tests, compare the function result directly:
assert split_integer.split_integer(17, 4) == [4, 4, 4, 5]