Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions app/test_split_integer.py
Original file line number Diff line number Diff line change
@@ -1,21 +1,25 @@
from app.split_integer import split_integer
from app import split_integer


def test_sum_of_the_parts_should_be_equal_to_value() -> None:
pass
result = split_integer.split_integer(17, 4)

assert sum(result) == 17
Comment on lines 4 to +7

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist item #1 violation: This stores the result in a variable before asserting. For simple tests, compare the function result directly: assert split_integer.split_integer(17, 4) == [4, 4, 4, 5]

assert len(result) == 4
assert max(result) - min(result) <= 1


def test_should_split_into_equal_parts_when_value_divisible_by_parts() -> None:
pass
assert split_integer.split_integer(12, 4) == [3, 3, 3, 3]


def test_should_return_part_equals_to_value_when_split_into_one_part() -> None:
pass
assert split_integer.split_integer(8, 1) == [8]


def test_parts_should_be_sorted_when_they_are_not_equal() -> None:
pass
assert split_integer.split_integer(11, 4) == [2, 3, 3, 3]


def test_should_add_zeros_when_value_is_less_than_number_of_parts() -> None:
pass
assert split_integer.split_integer(3, 5) == [0, 0, 1, 1, 1]
Loading