Skip to content

fix(release): drop per-object ACL from S3 blob uploads #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josegironn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(release): drop per-object ACL from S3 blob uploads #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,7 @@ blobs:
bucket: major-cli-releases
region: us-west-1
directory: "{{ .Version }}"
acl: public-read
# Public read is served by the bucket policy on major-cli-releases
# (terraform/global/releases.tf in mono-builder); goreleaser must not set
# per-object ACLs - its ACL upload path regressed under version: latest
# and broke the v1.0.9 release twice ("could not apply before write").
Loading