fix(release): drop per-object ACL from S3 blob uploads - #138
Open
josegironn wants to merge 1 commit into
Open
Conversation
The v1.0.9 release failed twice at the blob publish step ("could not
apply before write") - goreleaser's per-object ACL path under
version: latest. Public read is already served by the bucket policy
on major-cli-releases, so the ACL is unnecessary as well as broken.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Sr2JDGa6iLoTHnqwHe7Ltf
Co-authored-by: Orca <help@stably.ai>
josegironn
requested review from
exymax,
jasonzbao and
rishikesh-major
as code owners
July 24, 2026 04:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.0.9 release failed twice at the S3 publish step with goreleaser's
could not apply before write— its per-objectacl: public-readupload path regressed underversion: latest(the failure happens in goreleaser's ACL callback before any AWS call; binaries built fine both times).Public read on
major-cli-releasesis already served by the bucket policy (terraform/global/releases.tf in mono-builder), so per-object ACLs are unnecessary as well as broken. This drops theaclfrom the blobs config, with a comment explaining why it must not return.After merge, re-tag to release:
git tag -d v1.0.9 && git push origin :refs/tags/v1.0.9 && git tag -a v1.0.9 -m v1.0.9 <new-main-sha> && git push origin v1.0.9(nothing was ever published for v1.0.9 — no GitHub release, no S3 artifacts — so reusing the tag is clean), or just cut v1.0.10.🤖 Generated with Claude Code
https://claude.ai/code/session_01Sr2JDGa6iLoTHnqwHe7Ltf
Made with Orca 🐋